From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F1C2C001DC for ; Sat, 29 Jul 2023 07:38:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbjG2Hib (ORCPT ); Sat, 29 Jul 2023 03:38:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbjG2HiY (ORCPT ); Sat, 29 Jul 2023 03:38:24 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E68F54492 for ; Sat, 29 Jul 2023 00:38:22 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99bd1d0cf2fso401736466b.3 for ; Sat, 29 Jul 2023 00:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1690616301; x=1691221101; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=IYmWtjCeCkbkXYXMidyXsHWo/uzc6Q0z95DnXsdb6Jk=; b=Ut1CWQVuoMLWFKzhCEeRWNrfILigN3hwnJXELqS2Tsfgnn3fFk2TtGyJAzjAj5wGEA sNipHCgNMxUMrgl7nescH6w++92Hb6aQiDANbCUKSWm8nzmINfUaAvlXNQcLqjtL2I3+ enz93UK0DlVK8+cta6KaXLupiTePyrO5Hriwxh8lFtelzsB2raxvmYI1/RkfKtyzsB6x xWlmXhc0SpGkcPfWHr9tectW+YjxDC3M3yxfNMFziU7BBL7nHRpDeLc1luZT8v2fPWgQ yrYMEYjOMuO3tiMBJmnqpRaJ4UxvaR5S6If5xytfRSueIvZvYxd/kgMfYtBaZ429//Dn LkKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690616301; x=1691221101; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IYmWtjCeCkbkXYXMidyXsHWo/uzc6Q0z95DnXsdb6Jk=; b=P6dG3Cm9/mraaWwxD9JcYbIXRYFTNpR1EpPJK8CsGXq9TjJoKxMwspPLiq5Wqy88YL PKnylVd2z/HFPvlMlJqkj6fujDMPUoMGS3uHu2/gjiAYQTaWkkb6JyU9ceGv1ouMqNai SPg3/oJ4fi30L37uPop+lgP66iArReAfArtcWk8ZCVJVW9tg91DpplfthD52EXk4Bzi1 DjqtvS4Im5jPdZ9StdbqXKZ0teM7eRnhBaE0WtCJH4VMIAAnTO87UauTq1fXDUBDInUw EoYaJ5gedj3docEsDUhSofo/yIHOpLqRfybJqgPBaK8eC8R5xQf8Me2VD+m9GgM9vXHS SxRw== X-Gm-Message-State: ABy/qLZ4GsL1O5cXcLqHetYJlDIKlr27YJCMYMVb9ID+rPtj4lt9O5Ap RVfXRusOyN8ezrtiAQ+WcyL6kg== X-Google-Smtp-Source: APBJJlE05iU3+hYWOPGNmt1tk5T+oJvM8YCFPE9dtxhtPAlwF0v+PGLvzacP+3sj+ZuHwVpYnCzI/w== X-Received: by 2002:a17:906:74d6:b0:99b:e03b:3968 with SMTP id z22-20020a17090674d600b0099be03b3968mr1356267ejl.64.1690616301218; Sat, 29 Jul 2023 00:38:21 -0700 (PDT) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id kk9-20020a170907766900b00982cfe1fe5dsm3000715ejc.65.2023.07.29.00.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jul 2023 00:38:20 -0700 (PDT) Date: Sat, 29 Jul 2023 09:38:19 +0200 From: Andrew Jones To: Ian Rogers Cc: Alexandre Ghiti , Jonathan Corbet , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Anup Patel , Will Deacon , Rob Herring , =?utf-8?B?UsOpbWk=?= Denis-Courmont , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Atish Patra Subject: Re: [PATCH v4 10/10] perf: tests: Adapt mmap-basic.c for riscv Message-ID: <20230729-b5ec43a48d67caf13025fafe@orel> References: <20230727141428.962286-1-alexghiti@rivosinc.com> <20230727141428.962286-11-alexghiti@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Jul 28, 2023 at 10:54:02AM -0700, Ian Rogers wrote: > On Thu, Jul 27, 2023 at 7:30 AM Alexandre Ghiti wrote: > > > > riscv now supports mmaping hardware counters to userspace so adapt the test > > to run on this architecture. > > > > Signed-off-by: Alexandre Ghiti > > Reviewed-by: Andrew Jones > > Reviewed-by: Atish Patra > > --- > > tools/perf/tests/mmap-basic.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c > > index e68ca6229756..f5075ca774f8 100644 > > --- a/tools/perf/tests/mmap-basic.c > > +++ b/tools/perf/tests/mmap-basic.c > > @@ -284,7 +284,7 @@ static struct test_case tests__basic_mmap[] = { > > "permissions"), > > TEST_CASE_REASON("User space counter reading of instructions", > > mmap_user_read_instr, > > -#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) > > +#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) || __riscv_xlen == 64 > > Same comment relating to the guard, why not defined(__riscv) ? __riscv_xlen will always be defined for all riscv targets, so also checking __riscv isn't necessary when a specific bit width also needs to be checked. __riscv is useful for checks that don't need to be concerned with the bit width. Grepping, I see instances of both "defined(__riscv) && __riscv_xlen ==" and just "__riscv_xlen ==". IMHO, the former should be reduced to the latter, rather than creating more instances of them. Thanks, drew