From: Jakub Kicinski <kuba@kernel.org>
To: Lin Ma <linma@zju.edu.cn>
Cc: corbet@lwn.net, void@manifault.com, jani.nikula@intel.com,
rdunlap@infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] docs: staging: add netlink attrs best practices
Date: Tue, 8 Aug 2023 12:37:55 -0700 [thread overview]
Message-ID: <20230808123755.43610137@kernel.org> (raw)
In-Reply-To: <20230808035636.148552-1-linma@zju.edu.cn>
On Tue, 8 Aug 2023 11:56:36 +0800 Lin Ma wrote:
> Provide some suggestions that who deal with Netlink code could follow
> (of course using the word "best-practices" may sound somewhat
> exaggerate).
>
> According to my recent practices, the parsing of the Netlink attributes
> lacks documents for kernel developers. Since recently the relevant docs
> for Netlink user space get replenished, I guess is a good chance for
> kernel space part to catch with.
>
> First time to write a document and any reviews are appreciated.
Oh, you put quite some effort into this!
I have a hard time coming up with reasonable review comments, because
while the doc is informative and pretty correct, it focuses on what's
legacy use of netlink at this point. People writing new code will only
get confuse with this information :(
Modern families are all generic netlink, and validation is taken care
of in the core :(
If you post a v2 please make sure to CC netdev@
next parent reply other threads:[~2023-08-08 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230808035636.148552-1-linma@zju.edu.cn>
2023-08-08 19:37 ` Jakub Kicinski [this message]
2023-08-09 1:25 ` [PATCH v1] docs: staging: add netlink attrs best practices Lin Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808123755.43610137@kernel.org \
--to=kuba@kernel.org \
--cc=corbet@lwn.net \
--cc=jani.nikula@intel.com \
--cc=linma@zju.edu.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).