linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Min-Hua Chen <minhuadotchen@gmail.com>
To: corbet@lwn.net
Cc: linux-doc-tw-discuss@lists.sourceforge.net,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	minhuadotchen@gmail.com, rdunlap@infradead.org, src.res@email.cn
Subject: Re: [PATCH 2/2] docs: sparse: convert TW sparse.txt into sparse.rst
Date: Sat, 12 Aug 2023 08:37:15 +0800	[thread overview]
Message-ID: <20230812003715.7551-1-minhuadotchen@gmail.com> (raw)
In-Reply-To: <87a5uxxqf3.fsf@meer.lwn.net>

Hi Jonathan,

>> Follow Randy's advice [1] to move
>> Documentation/translations/zh_TW/dev-tools/sparse.txt
>> to
>> Documentation/translations/zh_TW/dev-tools/sparse.rst
>>
>> [1] https://lore.kernel.org/lkml/bfab7c5b-e4d3-d8d9-afab-f43c0cdf26cf@inf=
>radead.org/
>
>So the right way to do this would be to simply say something like
>"Convert sparse.txt to RST", then add a Suggested-by: tag to credit
>Randy.=20

Got it, I will submit v2 with this subject and add Suggested-by: tag
to credit Randy.

>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
>> ---
>>  .../dev-tools/{sparse.txt =3D> sparse.rst}      | 31 ++++++-------------
>>  1 file changed, 10 insertions(+), 21 deletions(-)
>>  rename Documentation/translations/zh_TW/dev-tools/{sparse.txt =3D> spars=
>e.rst} (71%)
>
>You're not adding this new document to a toctree anywhere; that will add
>a warning and this file won't be a part of the docs build.

I will fix this in v2.

>> diff --git a/Documentation/translations/zh_TW/dev-tools/sparse.txt b/Docu=
>mentation/translations/zh_TW/dev-tools/sparse.rst
>> similarity index 71%
>> rename from Documentation/translations/zh_TW/dev-tools/sparse.txt
>> rename to Documentation/translations/zh_TW/dev-tools/sparse.rst
>> index 6d2d088b1060..2f632f6ce8e8 100644
>> --- a/Documentation/translations/zh_TW/dev-tools/sparse.txt
>> +++ b/Documentation/translations/zh_TW/dev-tools/sparse.rst
>> @@ -1,33 +1,22 @@
>> -=EF=BB=BFChinese translated version of Documentation/dev-tools/sparse.rst
>> -
>> -If you have any comment or update to the content, please contact the
>> -original document maintainer directly.  However, if you have a problem
>> -communicating in English you can also ask the Chinese maintainer for
>> -help.  Contact the Chinese maintainer if this translation is outdated
>> -or if there is a problem with the translation.
>> +=EF=BB=BFCopyright 2004 Linus Torvalds
>> +Copyright 2004 Pavel Machek <pavel@ucw.cz>
>> +Copyright 2006 Bob Copeland <me@bobcopeland.com>
>>=20=20
>> -Traditional Chinese maintainer: Hu Haowen <src.res@email.cn>
>
>So you are removing a fair amount of text here, much of which I cannot
>read.  Why are you doing that?  In any case, that would appear to be a
>change that is independent of the format conversion, and should thus be
>in its own patch.

The text I removed is replaced by '.. include:: ../disclaimer-zh_TW.rst'.
I will keep the original text and change it in another change.

thanks,
Min-Hua

>
>Thanks,
>
>jon
>

      reply	other threads:[~2023-08-12  0:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230811153554.84571-1-minhuadotchen@gmail.com>
2023-08-11 15:35 ` [PATCH 1/2] docs: sparse: move TW sparse.txt to TW dev-tools Min-Hua Chen
2023-08-11 17:02   ` Randy Dunlap
2023-08-11 15:35 ` [PATCH 2/2] docs: sparse: convert TW sparse.txt into sparse.rst Min-Hua Chen
2023-08-11 17:02   ` Randy Dunlap
2023-08-11 20:41   ` Jonathan Corbet
2023-08-12  0:37     ` Min-Hua Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230812003715.7551-1-minhuadotchen@gmail.com \
    --to=minhuadotchen@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc-tw-discuss@lists.sourceforge.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=src.res@email.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).