From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA8EC001B0 for ; Sat, 12 Aug 2023 10:37:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236564AbjHLKhB (ORCPT ); Sat, 12 Aug 2023 06:37:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbjHLKhA (ORCPT ); Sat, 12 Aug 2023 06:37:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BE681720; Sat, 12 Aug 2023 03:37:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 09E46633F6; Sat, 12 Aug 2023 10:37:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA72BC433C7; Sat, 12 Aug 2023 10:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691836623; bh=OOJFg8XIcre5PyQ69RhHAT5dIZwp2zfWlsAoioRz2GI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jF47yuQn2QGRWstkmzhsYPznr1T+DK0+OMkumOJ9etL38UamMYT+z0wwI0kXBgtj5 peXk6t9OFJJmaxFOR+j0TBjokaSLAb2pePk4yyRZPSDO5NrbCWa1003kZY35IL1ySs ik+J/BYTHAlDqPSo7bG5urxX6FZ7KpGVERqU2FEY= Date: Sat, 12 Aug 2023 12:37:00 +0200 From: Greg KH To: Georgi Djakov Cc: Mike Tipton , rafael@kernel.org, corbet@lwn.net, linux-pm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_okukatla@quicinc.com, quic_viveka@quicinc.com, peterz@infradead.org, quic_pkondeti@quicinc.com Subject: Re: [PATCH v3 1/3] debugfs: Add write support to debugfs_create_str() Message-ID: <2023081237-grinch-degrease-0eb9@gregkh> References: <20230807142914.12480-1-quic_mdtipton@quicinc.com> <20230807142914.12480-2-quic_mdtipton@quicinc.com> <58ea6863-53cd-228b-1474-f67b0bb134f0@kernel.org> <2023081256-fastness-marine-609f@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023081256-fastness-marine-609f@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Sat, Aug 12, 2023 at 12:36:12PM +0200, Greg KH wrote: > On Fri, Aug 11, 2023 at 10:46:34AM +0300, Georgi Djakov wrote: > > On 7.08.23 17:29, Mike Tipton wrote: > > > Currently, debugfs_create_str() only supports reading strings from > > > debugfs. Add support for writing them as well. > > > > > > Based on original implementation by Peter Zijlstra [0]. Write support > > > was present in the initial patch version, but dropped in v2 due to lack > > > of users. We have a user now, so reintroduce it. > > > > > > [0] https://lore.kernel.org/all/YF3Hv5zXb%2F6lauzs@hirez.programming.kicks-ass.net/ > > > > > > > Hi Greg, > > > > Looks like the original code was reviewed two years ago (not sure if it > > counts). But in any case, i need an ack from you to apply this. > > > > There is no build dependency with the rest of the patches (but there is a > > functional one). It should be also fine if you apply it directly, if you > > prefer so? > > Feel free for this to go with the code that uses it: > > Acked-by: Greg Kroah-Hartman Wait, no, this isn't ok, this ACK is now rescinded: NACKED-by: Greg Kroah-Hartman