From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nicolas Schier <nicolas@fjasle.eu>,
Jonathan Corbet <corbet@lwn.net>,
Tomasz Figa <tfiga@chromium.org>,
linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [RFC][PATCH] kconfig: introduce listunknownconfig
Date: Sun, 20 Aug 2023 13:58:29 +0900 [thread overview]
Message-ID: <20230820045829.GL907732@google.com> (raw)
In-Reply-To: <20230820024519.GK907732@google.com>
On (23/08/20 11:45), Sergey Senozhatsky wrote:
> >
> > A new target is not what I like to see.
> >
> >
> > We decided to add KCONFIG_VERBOSE, which will be used to
> > warn options accidentally disabled or downgraded.
>
> That doesn't seem cover the cases that I'm concerned with. I don't see
> anything related to "!sym" in the patch.
>
> What will KCONFIG_VERBOSE do if it reads the following config file?
>
> // assuming that both config options were valid and existed in the old
> // kernel, but were removed/renamed in the new kernel
>
> $ cat .config
> CONFIG_DISABLE_BUGS=y
> # CONFIG_ENABLE_WINAPI is not set
>
>
> I'd like to see warnings for both lines, even for config that is not
> set, because it maybe we set by a build script depending on USE flags
> for instance, so that build target may still refer to non-existent
> config.
It's also important to exit with an error when non-existent config symbols
are detected. Because that is an error. We are looking at a broken kernel
from the end user PoV: the kernel will compile, get rolled out and at some
point you'll start receiving bug reports of non-functioning peripheral
hardware and whatnot (e.g. some specific USB devices whose config symbol
has been renamed).
So `make FOO-config` should never succeed if old config contains unrecognized
symbols, it should never get to the compilation stage.
That is not what KCONFIG_VERBOSE does (at least in its current form),
as far as I can tell.
next prev parent reply other threads:[~2023-08-20 5:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 1:19 [RFC][PATCH] kconfig: introduce listunknownconfig Sergey Senozhatsky
2023-08-17 3:44 ` Sergey Senozhatsky
2023-08-19 23:19 ` Masahiro Yamada
2023-08-20 2:45 ` Sergey Senozhatsky
2023-08-20 4:58 ` Sergey Senozhatsky [this message]
2023-08-20 5:11 ` Masahiro Yamada
2023-08-20 7:21 ` Sergey Senozhatsky
2023-08-20 7:33 ` Sergey Senozhatsky
2023-08-21 12:27 ` Masahiro Yamada
2023-08-21 16:08 ` Sergey Senozhatsky
2023-08-22 6:12 ` Sergey Senozhatsky
2023-08-24 1:00 ` Masahiro Yamada
2023-08-24 1:20 ` Sergey Senozhatsky
2023-08-26 1:12 ` Masahiro Yamada
2023-08-26 5:38 ` Masahiro Yamada
2023-08-26 5:53 ` Sergey Senozhatsky
2023-08-24 1:51 ` Tomasz Figa
2023-08-26 1:10 ` Masahiro Yamada
2023-08-26 2:10 ` Sergey Senozhatsky
2023-08-30 7:30 ` Tomasz Figa
2023-08-31 15:28 ` Masahiro Yamada
2023-09-04 5:10 ` Tomasz Figa
2023-12-28 5:51 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820045829.GL907732@google.com \
--to=senozhatsky@chromium.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).