From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C52EE49A6 for ; Mon, 21 Aug 2023 14:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236170AbjHUOyU (ORCPT ); Mon, 21 Aug 2023 10:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236180AbjHUOyU (ORCPT ); Mon, 21 Aug 2023 10:54:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83395E2; Mon, 21 Aug 2023 07:54:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1944363A62; Mon, 21 Aug 2023 14:54:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EEB6C433C9; Mon, 21 Aug 2023 14:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692629657; bh=XXk4gJYl5yxoJ2sva9Ggeq+caYpVLV0EPr+AedA8LNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ry1vjrSYbat+DrNaJTNdYxqc8kp0Ft1J4x7PVUSo2JrI6QgKZWkP3Ga0jbriyqqj/ ieBXSM6HA3xGieSNUdpnwgpiw78B74VfiwlIZcyQORI3rUehrKT2Sxy3pddASr5KuB wLtXaflvI4LtbYj2u4clQ6cDuPjuEJLiChTB/jFsJn81EWzOQq2rQjAHXiJR/jgVLd +m9ftFi7qiCVOigKLZwNxlQqqw234ZOTtLFLMPqfubSOvOEMp1SBXJYYjOwN8UWg95 2iTqDRZ5wK0HhJxT1iUoQJ6aKT+ROaIN6bicw/ET7yz3cqWgKKzq5EOxXf6c26/Fcw fJqXaGSlzkaLw== Date: Mon, 21 Aug 2023 17:53:52 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, linux-doc@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 2/4] mm: Fix get_mctgt_type() kernel-doc Message-ID: <20230821145352.GC9849@kernel.org> References: <20230818200630.2719595-1-willy@infradead.org> <20230818200630.2719595-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818200630.2719595-3-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Aug 18, 2023 at 09:06:28PM +0100, Matthew Wilcox (Oracle) wrote: > Convert the return values to an ReST list and tidy up the wording while > I'm touching it. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport (IBM) > --- > mm/memcontrol.c | 31 +++++++++++++------------------ > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e041ba827e59..cd8b3ae6b8d9 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5850,25 +5850,20 @@ static int mem_cgroup_move_account(struct page *page, > * @ptent: the pte to be checked > * @target: the pointer the target page or swap ent will be stored(can be NULL) > * > - * Returns > - * 0(MC_TARGET_NONE): if the pte is not a target for move charge. > - * 1(MC_TARGET_PAGE): if the page corresponding to this pte is a target for > - * move charge. if @target is not NULL, the page is stored in target->page > - * with extra refcnt got(Callers should handle it). > - * 2(MC_TARGET_SWAP): if the swap entry corresponding to this pte is a > - * target for charge migration. if @target is not NULL, the entry is stored > - * in target->ent. > - * 3(MC_TARGET_DEVICE): like MC_TARGET_PAGE but page is device memory and > - * thus not on the lru. > - * For now we such page is charge like a regular page would be as for all > - * intent and purposes it is just special memory taking the place of a > - * regular page. > - * > - * See Documentations/vm/hmm.txt and include/linux/hmm.h > - * > - * Called with pte lock held. > + * Context: Called with pte lock held. > + * Return: > + * * MC_TARGET_NONE - If the pte is not a target for move charge. > + * * MC_TARGET_PAGE - If the page corresponding to this pte is a target for > + * move charge. If @target is not NULL, the page is stored in target->page > + * with extra refcnt got (Callers should handle it). > + * * MC_TARGET_SWAP - If the swap entry corresponding to this pte is a > + * target for charge migration. if @target is not NULL, the entry is stored > + * in target->ent. > + * * MC_TARGET_DEVICE - Like MC_TARGET_PAGE but page is device memory and > + * thus not on the lru. For now such page is charged like a regular page > + * would be as it is just special memory taking the place of a regular page. > + * See Documentations/vm/hmm.txt and include/linux/hmm.h > */ > - > static enum mc_target_type get_mctgt_type(struct vm_area_struct *vma, > unsigned long addr, pte_t ptent, union mc_target *target) > { > -- > 2.40.1 > -- Sincerely yours, Mike.