From: Conor Dooley <conor@kernel.org>
To: Sarah Walker <sarah.walker@imgtec.com>
Cc: dri-devel@lists.freedesktop.org, frank.binns@imgtec.com,
donald.robson@imgtec.com, boris.brezillon@collabora.com,
airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, corbet@lwn.net, christian.koenig@amd.com,
linus.walleij@linaro.org, matt.coster@imgtec.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, faith.ekstrand@collabora.com,
afd@ti.com, hns@goldelico.com, matthew.brost@intel.com,
luben.tuikov@amd.com, dakr@redhat.com
Subject: Re: [PATCH v6 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU
Date: Thu, 7 Sep 2023 11:20:50 +0100 [thread overview]
Message-ID: <20230907-22495ffd0407dacc5cf1cd12@fedora> (raw)
In-Reply-To: <20230906095542.3280699-4-sarah.walker@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
Hey,
On Wed, Sep 06, 2023 at 10:55:25AM +0100, Sarah Walker wrote:
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/soc/ti,sci_pm_domain.h>
> +
> + gpu: gpu@fd00000 {
This "gpu" label isn't used and can be dropped if you respin.
Otherwise, this seems fine to me,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> + compatible = "ti,am62-gpu", "img,img-axe";
> + reg = <0x0fd00000 0x20000>;
> + clocks = <&k3_clks 187 0>;
> + clock-names = "core";
> + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> + };
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-07 16:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 9:55 [PATCH v6 00/20] Imagination Technologies PowerVR DRM driver Sarah Walker
2023-09-06 9:55 ` [PATCH v6 01/20] sizes.h: Add entries between 32G and 64T Sarah Walker
2023-09-06 9:55 ` [PATCH v6 02/20] drm/gpuva_mgr: Helper to get range of unmap from a remap op Sarah Walker
2023-09-06 11:35 ` Maxime Ripard
2023-09-06 11:46 ` Sarah Walker
2023-09-07 12:14 ` Jani Nikula
2023-09-07 13:00 ` Donald Robson
2023-09-07 13:15 ` Jani Nikula
2023-09-06 9:55 ` [PATCH v6 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU Sarah Walker
2023-09-06 11:36 ` Maxime Ripard
2023-09-06 11:36 ` Maxime Ripard
2023-09-06 19:03 ` Linus Walleij
2023-09-07 10:20 ` Conor Dooley [this message]
2023-09-06 9:55 ` [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI Sarah Walker
[not found] ` <CAD_bs+qdnVPYbmtzqcpCC8xdLVNvDb8uNccsd=P6YX+sgMG6Xg@mail.gmail.com>
2023-09-22 18:46 ` Andrew Davis
2023-09-25 0:41 ` Dave Airlie
2023-09-06 9:55 ` [PATCH v6 05/20] drm/imagination: Add skeleton PowerVR driver Sarah Walker
2023-09-06 9:55 ` [PATCH v6 06/20] drm/imagination: Get GPU resources Sarah Walker
2023-09-06 9:55 ` [PATCH v6 08/20] drm/imagination: Add firmware and MMU related headers Sarah Walker
2023-09-06 11:55 ` Maxime Ripard
2023-09-06 9:55 ` [PATCH v6 10/20] drm/imagination: Add GPU ID parsing and firmware loading Sarah Walker
2023-09-06 9:55 ` [PATCH v6 12/20] drm/imagination: Implement power management Sarah Walker
2023-09-06 9:55 ` [PATCH v6 14/20] drm/imagination: Implement MIPS firmware processor and MMU support Sarah Walker
2023-09-06 9:55 ` [PATCH v6 15/20] drm/imagination: Implement free list and HWRT create and destroy ioctls Sarah Walker
2023-09-06 9:55 ` [PATCH v6 16/20] drm/imagination: Implement context creation/destruction ioctls Sarah Walker
2023-09-06 9:55 ` [PATCH v6 18/20] drm/imagination: Add firmware trace header Sarah Walker
2023-09-06 9:55 ` [PATCH v6 19/20] drm/imagination: Add firmware trace to debugfs Sarah Walker
2023-09-06 9:55 ` [PATCH v6 20/20] drm/imagination: Add driver documentation Sarah Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907-22495ffd0407dacc5cf1cd12@fedora \
--to=conor@kernel.org \
--cc=afd@ti.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=frank.binns@imgtec.com \
--cc=hns@goldelico.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sarah.walker@imgtec.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).