* [PATCH] [v2] Documentation: kbuild: explain handling optional dependencies
@ 2023-09-17 19:19 Arnd Bergmann
2023-09-25 7:06 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2023-09-17 19:19 UTC (permalink / raw)
To: Masahiro Yamada, Jonathan Corbet
Cc: Arnd Bergmann, Javier Martinez Canillas, Sakari Ailus,
Nicolas Schier, Nathan Chancellor, Nick Desaulniers, linux-kbuild,
linux-doc, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This problem frequently comes up in randconfig testing, with
drivers failing to link because of a dependency on an optional
feature.
The Kconfig language for this is very confusing, so try to
document it in "Kconfig hints" section.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: fix typos pointed out by Nicolas Schier
---
Documentation/kbuild/kconfig-language.rst | 26 +++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/Documentation/kbuild/kconfig-language.rst b/Documentation/kbuild/kconfig-language.rst
index 858ed5d80defe..0135905c0aa35 100644
--- a/Documentation/kbuild/kconfig-language.rst
+++ b/Documentation/kbuild/kconfig-language.rst
@@ -573,6 +573,32 @@ above, leading to:
bool "Support for foo hardware"
depends on ARCH_FOO_VENDOR || COMPILE_TEST
+Optional dependencies
+~~~~~~~~~~~~~~~~~~~~~
+
+Some drivers are able to optionally use a feature from another module
+or build cleanly with that module disabled, but cause a link failure
+when trying to use that loadable module from a built-in driver.
+
+The most common way to express this optional dependency in Kconfig logic
+uses the slightly counterintuitive::
+
+ config FOO
+ tristate "Support for foo hardware"
+ depends on BAR || !BAR
+
+This means that there is either a dependency on BAR that disallows
+the combination of FOO=y with BAR=m, or BAR is completely disabled.
+For a more formalized approach if there are multiple drivers that have
+the same dependency, a helper symbol can be used, like::
+
+ config FOO
+ tristate "Support for foo hardware"
+ depends on BAR_OPTIONAL
+
+ config BAR_OPTIONAL
+ def_tristate BAR || !BAR
+
Kconfig recursive dependency limitations
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [v2] Documentation: kbuild: explain handling optional dependencies
2023-09-17 19:19 [PATCH] [v2] Documentation: kbuild: explain handling optional dependencies Arnd Bergmann
@ 2023-09-25 7:06 ` Masahiro Yamada
2024-02-15 12:38 ` Nicolas Schier
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2023-09-25 7:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jonathan Corbet, Arnd Bergmann, Javier Martinez Canillas,
Sakari Ailus, Nicolas Schier, Nathan Chancellor, Nick Desaulniers,
linux-kbuild, linux-doc, linux-kernel
On Mon, Sep 18, 2023 at 4:20 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> This problem frequently comes up in randconfig testing, with
> drivers failing to link because of a dependency on an optional
> feature.
>
> The Kconfig language for this is very confusing, so try to
> document it in "Kconfig hints" section.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: fix typos pointed out by Nicolas Schier
Applied to linux-kbuild. Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [v2] Documentation: kbuild: explain handling optional dependencies
2023-09-25 7:06 ` Masahiro Yamada
@ 2024-02-15 12:38 ` Nicolas Schier
2024-02-15 13:40 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Schier @ 2024-02-15 12:38 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, Jonathan Corbet, Arnd Bergmann,
Javier Martinez Canillas, Sakari Ailus, Nathan Chancellor,
Nick Desaulniers, linux-kbuild, linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Mon 25 Sep 2023 16:06:41 GMT, Masahiro Yamada wrote:
> On Mon, Sep 18, 2023 at 4:20 AM Arnd Bergmann <arnd@kernel.org>
> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > This problem frequently comes up in randconfig testing, with
> > drivers failing to link because of a dependency on an optional
> > feature.
> >
> > The Kconfig language for this is very confusing, so try to
> > document it in "Kconfig hints" section.
> >
> > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > v2: fix typos pointed out by Nicolas Schier
>
>
> Applied to linux-kbuild. Thanks.
Hi Masahiro,
this patch seems to got lost, or did you intentionally removed it
again?
Kind regards,
Nicolas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [v2] Documentation: kbuild: explain handling optional dependencies
2024-02-15 12:38 ` Nicolas Schier
@ 2024-02-15 13:40 ` Masahiro Yamada
2024-02-15 13:51 ` Nicolas Schier
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2024-02-15 13:40 UTC (permalink / raw)
To: Nicolas Schier
Cc: Arnd Bergmann, Jonathan Corbet, Arnd Bergmann,
Javier Martinez Canillas, Sakari Ailus, Nathan Chancellor,
Nick Desaulniers, linux-kbuild, linux-doc, linux-kernel
On Thu, Feb 15, 2024 at 9:39 PM Nicolas Schier <nicolas@fjasle.eu> wrote:
>
> On Mon 25 Sep 2023 16:06:41 GMT, Masahiro Yamada wrote:
> > On Mon, Sep 18, 2023 at 4:20 AM Arnd Bergmann <arnd@kernel.org>
> > wrote:
> > >
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > This problem frequently comes up in randconfig testing, with
> > > drivers failing to link because of a dependency on an optional
> > > feature.
> > >
> > > The Kconfig language for this is very confusing, so try to
> > > document it in "Kconfig hints" section.
> > >
> > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > v2: fix typos pointed out by Nicolas Schier
> >
> >
> > Applied to linux-kbuild. Thanks.
>
> Hi Masahiro,
>
> this patch seems to got lost, or did you intentionally removed it
> again?
>
> Kind regards,
> Nicolas
Oh?
I can see it in the mainline.
commit 28d49e171676afb7df7f47798391364af9abed7f
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Sun Sep 17 21:19:59 2023 +0200
Commit: Masahiro Yamada <masahiroy@kernel.org>
CommitDate: Mon Sep 25 16:01:05 2023 +0900
Documentation: kbuild: explain handling optional dependencies
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] [v2] Documentation: kbuild: explain handling optional dependencies
2024-02-15 13:40 ` Masahiro Yamada
@ 2024-02-15 13:51 ` Nicolas Schier
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Schier @ 2024-02-15 13:51 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, Jonathan Corbet, Arnd Bergmann,
Javier Martinez Canillas, Sakari Ailus, Nathan Chancellor,
Nick Desaulniers, linux-kbuild, linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
On Thu 15 Feb 2024 22:40:46 GMT, Masahiro Yamada wrote:
> On Thu, Feb 15, 2024 at 9:39 PM Nicolas Schier <nicolas@fjasle.eu>
> wrote:
> >
> > On Mon 25 Sep 2023 16:06:41 GMT, Masahiro Yamada wrote:
> > > On Mon, Sep 18, 2023 at 4:20 AM Arnd Bergmann <arnd@kernel.org>
> > > wrote:
> > > >
> > > > From: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > This problem frequently comes up in randconfig testing, with
> > > > drivers failing to link because of a dependency on an optional
> > > > feature.
> > > >
> > > > The Kconfig language for this is very confusing, so try to
> > > > document it in "Kconfig hints" section.
> > > >
> > > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> > > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > > Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > ---
> > > > v2: fix typos pointed out by Nicolas Schier
> > >
> > >
> > > Applied to linux-kbuild. Thanks.
> >
> > Hi Masahiro,
> >
> > this patch seems to got lost, or did you intentionally removed it
> > again?
> >
> > Kind regards,
> > Nicolas
>
>
>
> Oh?
>
> I can see it in the mainline.
ups, I'm sorry for the noise. You are right, I had an heavily
out-dated tree at hand and wasn't aware of it ...
Kind regards,
Nicolas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-15 13:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-17 19:19 [PATCH] [v2] Documentation: kbuild: explain handling optional dependencies Arnd Bergmann
2023-09-25 7:06 ` Masahiro Yamada
2024-02-15 12:38 ` Nicolas Schier
2024-02-15 13:40 ` Masahiro Yamada
2024-02-15 13:51 ` Nicolas Schier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).