From: Stephen Hemminger <stephen@networkplumber.org>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Yuchung Cheng <ycheng@google.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"ncardwell@google.com" <ncardwell@google.com>,
"kuniyu@amazon.com" <kuniyu@amazon.com>,
"morleyd@google.com" <morleyd@google.com>,
"mfreemon@cloudflare.com" <mfreemon@cloudflare.com>,
"mubashirq@google.com" <mubashirq@google.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"weiwan@google.com" <weiwan@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl
Date: Tue, 10 Oct 2023 19:15:42 -0700 [thread overview]
Message-ID: <20231010191542.3688fe24@hermes.local> (raw)
In-Reply-To: <PH7PR21MB3116FC142CAECCD5D981C530CACDA@PH7PR21MB3116.namprd21.prod.outlook.com>
On Tue, 10 Oct 2023 22:59:49 +0000
Haiyang Zhang <haiyangz@microsoft.com> wrote:
> > > If this an application specific optimization, it should be in a socket option
> > > rather than system wide via sysctl.
> > Initially I had a similar comment but later decided a sysctl could
> > still be useful if
> > 1) the entire host (e.g. virtual machine) is dedicated to that application
> > 2) that application is difficult to change
>
> Yes, the customer actually wants a global setting. But as suggested by Neal,
> I changed it to be per-namespace to match other TCP tunables.
Like congestion control choice, it could be both a sysctl and a socket option.
The reason is that delayed ack is already controlled by socket options.
next prev parent reply other threads:[~2023-10-11 2:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 19:23 [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl Haiyang Zhang
2023-10-10 20:06 ` Neal Cardwell
2023-10-10 21:05 ` Haiyang Zhang
2023-10-10 20:11 ` Kuniyuki Iwashima
2023-10-10 21:09 ` Haiyang Zhang
2023-10-10 22:14 ` Stephen Hemminger
2023-10-10 22:27 ` Yuchung Cheng
2023-10-10 22:59 ` Haiyang Zhang
2023-10-11 2:15 ` Stephen Hemminger [this message]
2023-10-11 18:49 ` Haiyang Zhang
2023-10-11 18:57 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010191542.3688fe24@hermes.local \
--to=stephen@networkplumber.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=kys@microsoft.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfreemon@cloudflare.com \
--cc=morleyd@google.com \
--cc=mubashirq@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).