From: Peter Zijlstra <peterz@infradead.org>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
tony.luck@intel.com, ak@linux.intel.com,
tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kvm@vger.kernel.org,
Alyssa Milburn <alyssa.milburn@linux.intel.com>,
Daniel Sneddon <daniel.sneddon@linux.intel.com>,
antonio.gomez.iglesias@linux.intel.com,
Alyssa Milburn <alyssa.milburn@intel.com>
Subject: Re: [PATCH v2 1/6] x86/bugs: Add asm helpers for executing VERW
Date: Tue, 24 Oct 2023 12:36:01 +0200 [thread overview]
Message-ID: <20231024103601.GH31411@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20231024-delay-verw-v2-1-f1881340c807@linux.intel.com>
On Tue, Oct 24, 2023 at 01:08:21AM -0700, Pawan Gupta wrote:
> +.macro CLEAR_CPU_BUFFERS
> + ALTERNATIVE "jmp .Lskip_verw_\@;", "jmp .Ldo_verw_\@", X86_FEATURE_CLEAR_CPU_BUF
> + /* nopl __KERNEL_DS(%rax) */
> + .byte 0x0f, 0x1f, 0x80, 0x00, 0x00;
> +.Lverw_arg_\@: .word __KERNEL_DS;
> +.Ldo_verw_\@: verw _ASM_RIP(.Lverw_arg_\@);
> +.Lskip_verw_\@:
> +.endm
Why can't this be:
ALTERNATIVE "". "verw _ASM_RIP(mds_verw_sel)", X86_FEATURE_CLEAR_CPU_BUF
And have that mds_verw_sel thing be out-of-line ? That gives much better
code for the case where we don't need this.
next prev parent reply other threads:[~2023-10-24 10:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 8:08 [PATCH v2 0/6] Delay VERW Pawan Gupta
2023-10-24 8:08 ` [PATCH v2 1/6] x86/bugs: Add asm helpers for executing VERW Pawan Gupta
2023-10-24 10:36 ` Peter Zijlstra [this message]
2023-10-24 16:35 ` Pawan Gupta
2023-10-24 16:36 ` Peter Zijlstra
2023-10-24 16:45 ` Pawan Gupta
2023-10-24 17:02 ` Peter Zijlstra
2023-10-24 17:30 ` Pawan Gupta
2023-10-24 18:27 ` H. Peter Anvin
2023-10-24 18:49 ` Luck, Tony
2023-10-24 19:14 ` H. Peter Anvin
2023-10-24 19:40 ` Luck, Tony
2023-10-24 20:30 ` H. Peter Anvin
2023-10-24 22:30 ` Peter Zijlstra
2023-10-24 22:28 ` Peter Zijlstra
2023-10-25 4:00 ` Pawan Gupta
2023-10-25 6:56 ` Peter Zijlstra
2023-10-25 15:06 ` Pawan Gupta
2023-10-25 6:58 ` Peter Zijlstra
2023-10-25 15:10 ` Pawan Gupta
2023-10-24 8:08 ` [PATCH v2 2/6] x86/entry_64: Add VERW just before userspace transition Pawan Gupta
2023-10-24 8:08 ` [PATCH v2 3/6] x86/entry_32: " Pawan Gupta
2023-10-24 8:08 ` [PATCH v2 4/6] x86/bugs: Use ALTERNATIVE() instead of mds_user_clear static key Pawan Gupta
2023-10-25 22:08 ` kernel test robot
2023-10-24 8:08 ` [PATCH v2 5/6] KVM: VMX: Use BT+JNC, i.e. EFLAGS.CF to select VMRESUME vs. VMLAUNCH Pawan Gupta
2023-10-25 8:15 ` Nikolay Borisov
2023-10-24 8:08 ` [PATCH v2 6/6] KVM: VMX: Move VERW closer to VMentry for MDS mitigation Pawan Gupta
2023-10-25 7:47 ` Chao Gao
2023-10-25 15:15 ` Pawan Gupta
2023-10-24 12:26 ` [PATCH v2 0/6] Delay VERW Matthew Wilcox
2023-10-24 17:01 ` Pawan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024103601.GH31411@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=alyssa.milburn@intel.com \
--cc=alyssa.milburn@linux.intel.com \
--cc=antonio.gomez.iglesias@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox