From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 412A7134B1; Tue, 24 Oct 2023 13:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="fVfgHpnx" Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CED7395; Tue, 24 Oct 2023 06:40:41 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 694441BF210; Tue, 24 Oct 2023 13:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1698154840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XAvwTUEXIaI0z46pwJVVezsvG++BVtQgJpn7cNB1ctk=; b=fVfgHpnxlEj7KXhnlLkjkqIn4X+DlaVL28wNNDKsdKIyO3C3tvJQuTHYhg5CqnbLkuLnAJ MhjWilxmzP1cRei4l0+6prxLMziuTntq9RysPTZe30dYV50oRayMr13kCzvEzclbcaYryh ERnuCbdc2IHW4tbscWoIBlJ60sEyXnkg7y7EnGhxy0YUq0M5CPlkzk/nzoDiX74mJVuTCz IZWE0bfR+0kPEB5Wen0qms4C9EAH4tE8o6XR0LueVCj8q8PRwjegXINaoQdEeC8sZWBfZR WCKn4VSEZkKwpznLprcK4dM+i1TMkLP2POCtIyJUI0Q5OwBHZkyug+uSq8+HhQ== Date: Tue, 24 Oct 2023 15:40:37 +0200 From: =?UTF-8?B?S8O2cnk=?= Maincent To: Willem de Bruijn Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier Subject: Re: [PATCH net-next v6 07/16] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask Message-ID: <20231024154037.2f61fe5b@kmaincent-XPS-13-7390> In-Reply-To: References: <20231019-feature_ptp_netnext-v6-0-71affc27b0e5@bootlin.com> <20231019-feature_ptp_netnext-v6-7-71affc27b0e5@bootlin.com> Organization: bootlin X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com On Thu, 19 Oct 2023 10:48:04 -0400 Willem de Bruijn wrote: > On Thu, Oct 19, 2023 at 10:29=E2=80=AFAM Kory Maincent > wrote: > > > > Timestamping software or hardware flags are often used as a group, > > therefore adding these masks will easier future use. =20 >=20 > This assumes that device support for timestamping is often symmetric: > a device supports both rx and tx, or neither. > > All devices support software receive timestamping, as that timestamp > is taken in the core network stack. But to support transmit timestamps > drivers have to call sbk_tstamp_tx in their ndo_start_xmit. Yes, and in that software only case they often call ethtool_op_get_ts_info = to fill the timestamp info. There is several drivers that support hardware and software timestamp, these mask could be useful for these. In case of asymmetric support we can still = use the SOF_TIMESTAMPING_RX/TX_SOFTWARE flags. I forgot to specify, in the commit message but this patch is mainly to ease the next patch of this series to deal with software/hardware time stamping. Maybe you prefer to have this squash into next patch as had suggested Flori= an in last version. K=C3=B6ry