From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70EE015AE5 for ; Wed, 25 Oct 2023 15:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SVtr6NfL" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B533137; Wed, 25 Oct 2023 08:10:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698246623; x=1729782623; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=h5JI00UNVOxIMLEny8kw2e5sk3c/Y4lPR8sE6MoghvM=; b=SVtr6NfL6tFbGVgA65VUig3Lq7hnL/XH8qNRsRU1p/bCgAtm3LGQVQRf YwqSnKmPpyDwR6EsZRwNniDkdc4nGFcMNzqA6Q4yqKA7m92w363mrPm8C ekKC+9ScUB0wQUWOsqUlmE6sGPyyNBk2tHvkXb+aaL3tW/wI8Jdx5366b g2HqowT1jPGO09Siyz2s/Qg9WF/Pe7eDCr5k8R3tCSc/Apdhk1cx1Fcxx c9e+DBL/20HbfQmIcRNBCko6ELER21aByHLMsJpE/4UXtGDP3yR60Ug+3 zPBJVU96HR01K4vZ1AqQCC5Nv5E1xuAsBKt6KNqTTqd8Y2wZ2ccX642Qk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10874"; a="391197318" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="391197318" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 08:10:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="6570949" Received: from mhans-mobl3.amr.corp.intel.com (HELO desk) ([10.252.132.200]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 08:09:02 -0700 Date: Wed, 25 Oct 2023 08:10:01 -0700 From: Pawan Gupta To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Josh Poimboeuf , Andy Lutomirski , Jonathan Corbet , Sean Christopherson , Paolo Bonzini , tony.luck@intel.com, ak@linux.intel.com, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Alyssa Milburn , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com, Alyssa Milburn Subject: Re: [PATCH v2 1/6] x86/bugs: Add asm helpers for executing VERW Message-ID: <20231025151001.bhia5kxmld5dfgr7@desk> References: <20231024-delay-verw-v2-0-f1881340c807@linux.intel.com> <20231024-delay-verw-v2-1-f1881340c807@linux.intel.com> <20231024103601.GH31411@noisy.programming.kicks-ass.net> <20231025040029.uglv4dwmlnfhcjde@desk> <20231025065818.GB31201@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025065818.GB31201@noisy.programming.kicks-ass.net> On Wed, Oct 25, 2023 at 08:58:18AM +0200, Peter Zijlstra wrote: > > +.pushsection .rodata > > +.align 64 > > +mds_verw_sel: > > + .word __KERNEL_DS > > + .byte 0xcc > > +.align 64 > > +.popsection > > This should not be in a header file, you'll get an instance of this per > translation unit, not what you want. Agh, sorry I missed it.