From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
corbet@lwn.net, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, vladimir.oltean@nxp.com,
andrew@lunn.ch, horms@kernel.org, mkubecek@suse.cz,
willemdebruijn.kernel@gmail.com, gal@nvidia.com,
alexander.duyck@gmail.com, linux-doc@vger.kernel.org,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash
Date: Tue, 21 Nov 2023 15:33:58 -0800 [thread overview]
Message-ID: <20231121153358.3a6a09de@kernel.org> (raw)
In-Reply-To: <20231120205614.46350-3-ahmed.zaki@intel.com>
On Mon, 20 Nov 2023 13:56:09 -0700 Ahmed Zaki wrote:
> + * @data: Extension for the RSS hash function. Valid values are one of the
> + * %RXH_HFUNC_*.
@data is way too generic. Can we call this key_xfrm? key_preproc?
> +/* RSS hash function data
> + * XOR the corresponding source and destination fields of each specified
> + * protocol. Both copies of the XOR'ed fields are fed into the RSS and RXHASH
> + * calculation.
> + */
> +#define RXH_HFUNC_SYM_XOR (1 << 0)
We need to mention somewhere that sym-xor is unsafe, per Alex's
comments.
> +++ b/include/uapi/linux/ethtool_netlink.h
You need to fill in the details in:
Documentation/networking/ethtool-netlink.rst
and
Documentation/netlink/specs/ethtool.yaml
Last but not least please keep the field check you moved to the drivers
in the core. Nobody will remember to check that other drivers added the
check as well.
--
pw-bot: cr
next prev parent reply other threads:[~2023-11-21 23:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 20:56 [PATCH net-next v6 0/7] Support symmetric-xor RSS hash Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 1/7] net: ethtool: pass ethtool_rxfh to get/set_rxfh ethtool ops Ahmed Zaki
2023-11-21 23:29 ` Jakub Kicinski
2023-11-27 14:14 ` Ahmed Zaki
2023-11-27 16:55 ` Jakub Kicinski
2023-11-27 17:10 ` Edward Cree
2023-11-27 18:04 ` Jakub Kicinski
2023-11-28 20:19 ` Keller, Jacob E
2024-06-05 17:42 ` Gal Pressman
2024-06-05 17:56 ` Ahmed Zaki
2024-06-05 18:27 ` Keller, Jacob E
2023-11-20 20:56 ` [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash Ahmed Zaki
2023-11-21 23:33 ` Jakub Kicinski [this message]
2023-11-23 13:33 ` Gal Pressman
2023-11-23 16:27 ` Jakub Kicinski
2023-11-27 14:21 ` Ahmed Zaki
2023-11-27 16:57 ` Jakub Kicinski
2023-11-20 20:56 ` [PATCH net-next v6 3/7] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 4/7] ice: refactor RSS configuration Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 5/7] ice: refactor the FD and RSS flow ID generation Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 6/7] ice: enable symmetric-xor RSS for Toeplitz hash function Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 7/7] iavf: " Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121153358.3a6a09de@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).