From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9517584E8; Wed, 22 Nov 2023 18:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nQIgQnzE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0567C433C8; Wed, 22 Nov 2023 18:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700676111; bh=DWUiekk1hXft3g2yCopiERCaH6fhza4b69cZTvVcpdY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nQIgQnzE8sTuB2DQUrkEMhm03hfOt5YWmPcs0VsVDtftb/G48o6iBHxOmw20lS9be DaegCqg2DP/BsE/B8n4Bo+08u4yNMfJ8CJZdfsFovhf9u6eORI5FRqev+i/kIJABSs GZsh+6A2/E5VqM1izplteYHYi4FC5E8h+MfoSvq+GeA6WFIEPfaujwnXieIQ9O93h+ KEIamZvzC6GMENp4JuTC654m+8q97bu1fSkLR/gDkS6e8f7uXGn/yXa96YxBqVf2Og yntLYbTY6uMkbWuXOV003GzruNZm1V1isg/X+YMlt9/NiKwv651heL0bAY2ffsPmEP rqsT4iPbYwSSA== Date: Wed, 22 Nov 2023 10:01:42 -0800 From: Jakub Kicinski To: Vladimir Oltean Cc: =?UTF-8?B?S8O2cnk=?= Maincent , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier Subject: Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time stamping layer be selectable Message-ID: <20231122100142.338a2092@kernel.org> In-Reply-To: <20231122165517.5cqqfor3zjqgyoow@skbuf> References: <20231120190023.ymog4yb2hcydhmua@skbuf> <20231120115839.74ee5492@kernel.org> <20231120211759.j5uvijsrgt2jqtwx@skbuf> <20231120133737.70dde657@kernel.org> <20231120220549.cvsz2ni3wj7mcukh@skbuf> <20231121183114.727fb6d7@kmaincent-XPS-13-7390> <20231121094354.635ee8cd@kernel.org> <20231122144453.5eb0382f@kmaincent-XPS-13-7390> <20231122140850.li2mvf6tpo3f2fhh@skbuf> <20231122085000.79f2d14c@kernel.org> <20231122165517.5cqqfor3zjqgyoow@skbuf> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 22 Nov 2023 18:55:17 +0200 Vladimir Oltean wrote: > > Well, ethtool has been the catch all for a lot of random things > > for the longest time. The question is whether we want to extend > > ETHTOOL_GET_TS_INFO or add a third API somewhere else. And if we > > do - do we also duplicate the functionality of ETHTOOL_GET_TS_INFO > > (i.e. getting capabilities)? > > > > My vote is that keeping it in ethtool is less bad than 3rd API. > > With SIOCSHWTSTAMP also implemented by CAN (and presumably also by > wireless in the future), I do wonder whether ethtool is the right place > for the netlink conversion. ethtool currently provides the only way we have to configure ring length, ring count, RSS, UDP tunnels etc. It's a matter of taste, IMO ethtool is a bit of a lost cause already and keeping things together (ethtool already has TS_INFO) is cleaner than spreading them around. > I wouldn't suggest duplicating ETHTOOL_GET_TS_INFO towards the netdev > netlink family. FTR so far the netdev family is all about SW configuration. We should probably keep it that way, so it doesn't become ginormous. It's easy enough to create a new family, if needed.