From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="McHjE2uU"
Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff])
	by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3355171A;
	Thu, 30 Nov 2023 22:56:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type:
	MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=wLs+rj36TER3FAdhJUGWgB8svjJ4imeQUKcsqN9cuBs=; b=McHjE2uUoyuQUeUcBtDcmCqC6T
	mwafMy27E9ZKu5EkXlj+vRda6HSeH6xoZCe2BVPCtC8ZqfoTj3ng2SUX65H+AG083Ht2g0V5eAp3S
	pxU/ZxFddKyjh2c76mb/bKEiLgDz4CNw5tRtlDg8nONN0Kyz1t7bfpjDiHDBI8kKaV1XqEcUd0jQh
	BonZES/eusbpcZFYvVKmm42inhmgKuTwvZ7bUkunPxP5vcmofnDBCsGBAsHZJBGvMwWnuRyFcUsPe
	JLOfX1XWQPH3f1KW0R2Lu073JcKNnv7ro6zxRaW0f9xE7dSV3fKf7RkSdU1HlUkBuWSLC26rX54dV
	eh3G/fSA==;
Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux))
	id 1r8xRS-005knt-38;
	Fri, 01 Dec 2023 06:56:03 +0000
Date: Fri, 1 Dec 2023 06:56:02 +0000
From: Al Viro <viro@zeniv.linux.org.uk>
To: Oliver Sang <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>, linux-doc@vger.kernel.org,
	ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com
Subject: Re: [viro-vfs:work.dcache2] [__dentry_kill()]  1b738f196e:
 stress-ng.sysinfo.ops_per_sec -27.2% regression
Message-ID: <20231201065602.GP38156@ZenIV>
References: <202311300906.1f989fa8-oliver.sang@intel.com>
 <20231130075535.GN38156@ZenIV>
 <ZWlBNSblpWghkJyW@xsang-OptiPlex-9020>
 <20231201040951.GO38156@ZenIV>
Precedence: bulk
X-Mailing-List: linux-doc@vger.kernel.org
List-Id: <linux-doc.vger.kernel.org>
List-Subscribe: <mailto:linux-doc+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-doc+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231201040951.GO38156@ZenIV>
Sender: Al Viro <viro@ftp.linux.org.uk>

On Fri, Dec 01, 2023 at 04:09:51AM +0000, Al Viro wrote:
> On Fri, Dec 01, 2023 at 10:13:09AM +0800, Oliver Sang wrote:
> 
> > > Very interesting...  Out of curiosity, what effect would the following
> > > have on top of 1b738f196e?
> > 
> > I applied the patch upon 1b738f196e (as below fec356fd0c), but seems less
> > useful.
> 
> I would be rather surprised if it fixed anything; it's just that 1b738f196e
> changes two things - locking rules for __dentry_kill() and, in some cases,
> the order of dentry eviction in shrink_dentry_list().  That delta on top of
> it restores the original order in shrink_dentry_list(), leaving pretty much
> the changes in lock_for_kill()/dput()/__dentry_kill().
> 
> Interesting...  Looks like there are serious changes in context switch
> frequencies, but I don't see where could that have come from...

In principle it could be an effect of enforcing the ordering between __dentry_kill()
of child and parent, but if that's what is going on... we would've seen
more iterations of loop in shrink_dcache_parent() and/or d_walk() calls in
it having more work to do.  But... had that been what's going on, wouldn't we
see some of those functions in the changed part of profile?  

I'll try to split that thing into a series of steps, so we could at least narrow
the effect down, but that'll have to wait until tomorrow ;-/