From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 454A856748; Fri, 1 Dec 2023 20:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CJ1WjZYZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6952FC433C8; Fri, 1 Dec 2023 20:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701461112; bh=VZNoAqDPTg8yDoctRcEB3F3opYWUlSBiujMwK2WyTQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CJ1WjZYZ+qso1UgSidqe3y+J/eJKvHShQw2R3MIzQEk70r87eQP1DebG3EQAiSLIj IUqhHtHkfHjsuBzdihsJ/ioN6yOXRd3wk9v9HE6RTary1ugjedS5FIL4PVk+6wU/ez g9DPCfWdfABoNpMiyisxXIZsO0px3oHHZYB77AAaBAGg1g+WXNqe/+ZY/8Xs6oj+ud LBLNz8APsX4gnPGHkBG46TW0JkbA7erLdKsm+gCXkSOaxRnSHnSGmTAZx6/Eo8gWe0 0lOj7Mfj5wmuVLHJTKpo4wPE5uVmAJClr6yxMBQ67sBDQKBPKWsKgwaxLyKpz+g8rk EBv4asusLbiFg== Date: Fri, 1 Dec 2023 12:04:42 -0800 From: Josh Poimboeuf To: Andrew Cooper Cc: Pawan Gupta , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Andy Lutomirski , Jonathan Corbet , Sean Christopherson , Paolo Bonzini , tony.luck@intel.com, ak@linux.intel.com, tim.c.chen@linux.intel.com, Nikolay Borisov , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Alyssa Milburn , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com, Greg Kroah-Hartman , Alyssa Milburn Subject: Re: [PATCH v4 1/6] x86/bugs: Add asm helpers for executing VERW Message-ID: <20231201200442.lvyep5uqc6oa7kwj@treble> References: <20231027-delay-verw-v4-0-9a3622d4bcf7@linux.intel.com> <20231027-delay-verw-v4-1-9a3622d4bcf7@linux.intel.com> <20231201193657.mvzslo4nlcbuv2q4@treble> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Dec 01, 2023 at 07:39:05PM +0000, Andrew Cooper wrote: > On 01/12/2023 7:36 pm, Josh Poimboeuf wrote: > > On Fri, Oct 27, 2023 at 07:38:40AM -0700, Pawan Gupta wrote: > >> +.pushsection .entry.text, "ax" > >> + > >> +.align L1_CACHE_BYTES, 0xcc > >> +SYM_CODE_START_NOALIGN(mds_verw_sel) > >> + UNWIND_HINT_UNDEFINED > >> + ANNOTATE_NOENDBR > >> + .word __KERNEL_DS > >> +.align L1_CACHE_BYTES, 0xcc > >> +SYM_CODE_END(mds_verw_sel); > >> +/* For KVM */ > >> +EXPORT_SYMBOL_GPL(mds_verw_sel); > >> + > >> +.popsection > > This is data, so why is it "CODE" in .entry.text? > > Because KPTI. Urgh... Pawan please add a comment. -- Josh