From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="1R2kAnBC" Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C955DF for ; Sat, 2 Dec 2023 15:38:16 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-33338c47134so832430f8f.1 for ; Sat, 02 Dec 2023 15:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1701560295; x=1702165095; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=78CTgtpobZ3nEtM8PQVEaWzZpOWHKrFZDrmFfudY4xw=; b=1R2kAnBCUo3YLVXFCjgCC77NHDZknXpYL2MZaKIv4ooAX3lya0HjtXzIyAZwwOHm0W 0bvAjJXUq4+XqP5ylxG9wevLleWkAZl/zQy4jN9pp/1thXMXNFRKWUuUWiQX0FgAu6WM 2hKAjFE3B2SN3LD9UjevIEJAw2BZs+VkMe5zyK2L0zwY3NZimCbo+kukZyunHMK0AeTc BqNN17cwmx/MDTmD2lgXk7ArC7oHBh0fxVeBz7/a7Nq+Pebh2n500pblyGisxyyy5O02 yugP6YI/Zim5gFxWU+Ei5YdIYkHIntYK5C7BzRn+50cf4vHDQ2dL//zy9/jZCVZL/Xcq ZOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701560295; x=1702165095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=78CTgtpobZ3nEtM8PQVEaWzZpOWHKrFZDrmFfudY4xw=; b=iz44JbScmOuUiGOg1i5cAFJthxEQfyS8czQeRDIFqZ9Hg7RcocI6XBuDs3gQPWzaUa /IBu6txLHwEV5OLalL6SM880Q8mVD2QwTSobuNWpo3nSdzj3Rzf7rprs5qExdTEfnfv1 ZG0ZUtVwDtR8U3f3BQjG/QSHWzwteVKEO4w5rMquiq1x5Mf0DuaZNwwmR6iJ3DUA2/QF +sXdObovJaFkBSjbKu94+wrPHBi68gusiWvvr8vWEQhKlkClIQSjL5RA0fy/+GEcKDdO WXPvbqmLu9WCmCPh6CqpPpLat/gdLQsvcgjfJfAL38mTTj7tpJ8df043qtpfN1Fp2Pq8 +LZA== X-Gm-Message-State: AOJu0Yz304SNBbq7OOuEdpwJHu4I5ph4chyYfBYnRAOvotsHZGBrfcWd P2BZ8hD+b9dtQybNyWMEC9uOIQ== X-Google-Smtp-Source: AGHT+IEx5t/BgNVRyaVaB3TRTF8+1Lk+D/pbCaZ8YVruDsW3d7NeoSmshnu5HAXAbgWdo4ONaaM06w== X-Received: by 2002:a05:600c:5126:b0:3f6:9634:c8d6 with SMTP id o38-20020a05600c512600b003f69634c8d6mr1486941wms.18.1701560294174; Sat, 02 Dec 2023 15:38:14 -0800 (PST) Received: from airbuntu (host109-153-232-45.range109-153.btcentralplus.com. [109.153.232.45]) by smtp.gmail.com with ESMTPSA id g10-20020a05600c4eca00b0040596352951sm13712893wmq.5.2023.12.02.15.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 15:38:13 -0800 (PST) Date: Sat, 2 Dec 2023 23:38:12 +0000 From: Qais Yousef To: Vincent Guittot Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, corbet@lwn.net, alexs@kernel.org, siyanteng@loongson.cn, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, lukasz.luba@arm.com, hongyan.xia2@arm.com, yizhou.tang@shopee.com Subject: Re: [PATCH v2 2/2] sched/fair: Simplify util_est Message-ID: <20231202233812.cq2nodia3estdexy@airbuntu> References: <20231201161652.1241695-1-vincent.guittot@linaro.org> <20231201161652.1241695-3-vincent.guittot@linaro.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231201161652.1241695-3-vincent.guittot@linaro.org> On 12/01/23 17:16, Vincent Guittot wrote: > /* > * The load/runnable/util_avg accumulates an infinite geometric series > * (see __update_load_avg_cfs_rq() in kernel/sched/pelt.c). > @@ -505,9 +469,20 @@ struct sched_avg { > unsigned long load_avg; > unsigned long runnable_avg; > unsigned long util_avg; > - struct util_est util_est; > + unsigned int util_est; > } ____cacheline_aligned; unsigned long would be better?