From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZkSvzWFe" Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46F23112 for ; Thu, 14 Dec 2023 08:15:05 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1d351cb8b82so10267975ad.3 for ; Thu, 14 Dec 2023 08:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1702570505; x=1703175305; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z1Ou2BN/NSSGCNvRe4VvolyrUm7oUAf2oh76V3K9T9M=; b=ZkSvzWFe4GfrTmBb8iUOsSMZShHZoC/6pFizlZJfB9ONOgN3UTUwkKgX7kuJyqDJbT kavajsdaTI6rnXuGy85d33h+u8VKloOrALanp91z+RAAw++psw1KGHgu8zFL0gR5oymo S2PjEMBmoHCB52+2P6XENFdmySM51D5bZWxYQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702570505; x=1703175305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z1Ou2BN/NSSGCNvRe4VvolyrUm7oUAf2oh76V3K9T9M=; b=YNz5pur2BePW5JAtcpd9TlR6XTJL58+xuUT1XQBJSneht5gGCdhsCcrUvNGD6XUB/q ohl3JWFyH7nfcasjB5nOuEk4+ah2K3EK4AnPeU/b4ZoQJnpkj+x3AUm/Ti0dvqXfY+pD /Ib79IS+L1mOgvQ0bPH1JX3193m28VQUVwE10QxUmkJch/qfkXRK8lcF6Y6PQtBTYJLl TcJweEnWKuKljBk6RBFHWGpusZkmvv23ovsJ1fb6qbsIYEGgOdmpaFqYP/HpHisndYPt wqg40UJ/aRF3RCWmuNTMHg4zqcjMfpnHnjWx2eQ7bqy4h9U5XC13z7Hb2QY3y3KNiwA1 FKeQ== X-Gm-Message-State: AOJu0YyZCabjpyROLpA4xKdZHQwFa2n53RfoNxkEwiDp2XS5qw+mnJHo z4Xkjb0wspgkxt2mSqMvJ+GAhg== X-Google-Smtp-Source: AGHT+IH+ytQj5wa72LYKC5YIjqTselzMKodTANBeg8JotZhzXxmhWvXBDTQzTxLBsP0QwKZwCFxenA== X-Received: by 2002:a17:902:eb82:b0:1d3:4c35:17a0 with SMTP id q2-20020a170902eb8200b001d34c3517a0mr1926746plg.120.1702570504783; Thu, 14 Dec 2023 08:15:04 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id n6-20020a170902e54600b001d1cd7e4ad2sm12549781plf.125.2023.12.14.08.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 08:15:04 -0800 (PST) Date: Thu, 14 Dec 2023 08:15:03 -0800 From: Kees Cook To: davidgow@google.com Cc: Rae Moar , Brendan Higgins , Greg Kroah-Hartman , Matti Vaittinen , Stephen Boyd , Shuah Khan , Jonathan Corbet , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Maxime Ripard , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v3 3/5] overflow: Replace fake root_device with kunit_device Message-ID: <202312140814.314B59CD@keescook> References: <20231214-kunit_bus-v3-0-7e9a287d3048@google.com> <20231214-kunit_bus-v3-3-7e9a287d3048@google.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214-kunit_bus-v3-3-7e9a287d3048@google.com> On Thu, Dec 14, 2023 at 04:49:17PM +0800, davidgow@google.com wrote: > Using struct root_device to create fake devices for tests is something > of a hack. The new struct kunit_device is meant for this purpose, so use > it instead. > > Reviewed-by: Matti Vaittinen > Signed-off-by: David Gow Acked-by: Kees Cook -- Kees Cook