From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58EB7168A4; Wed, 20 Dec 2023 01:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EtaezQAv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703034954; x=1734570954; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HLyVwqO30briaKAvjBVfYYf6El0zpVQ8PfDWrML2yQc=; b=EtaezQAvR3uiFmKKbTWDWJyQ2GIdPKMyGR9IeNBJm1cTY/AZB/W8ZeEa FMSTTdwDzeZkA/xgEVolEccDVXkO0Eol6MaSkqmlIHd6e9nRpw0VKPZjw 86aU2Y6x+Q3wEzzkLNNDoReNxrK0YWCi9Ro4lY6IuOAraCcUmMK4viSV+ kBlL18yq9i83JQDiyk7G8LzOmXbZKBeTBAuEizMG1cmwfxlBcBHy89/un jQsJNkPN+P9rebmcl4oSJO9NGjUbHd2tqRPRUTTarBWgoKVs+vOd4f8Y/ mzkmLqgTMxjMK0N09rNxsat2P5XJn04vX/499wKtvrOu2wKUeE5QtCTSY A==; X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="394628811" X-IronPort-AV: E=Sophos;i="6.04,290,1695711600"; d="scan'208";a="394628811" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 17:15:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10929"; a="919798002" X-IronPort-AV: E=Sophos;i="6.04,290,1695711600"; d="scan'208";a="919798002" Received: from ihur-mobl1.amr.corp.intel.com (HELO desk) ([10.209.1.244]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2023 17:15:50 -0800 Date: Tue, 19 Dec 2023 17:15:35 -0800 From: Pawan Gupta To: Josh Poimboeuf Cc: Andrew Cooper , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Andy Lutomirski , Jonathan Corbet , Sean Christopherson , Paolo Bonzini , tony.luck@intel.com, ak@linux.intel.com, tim.c.chen@linux.intel.com, Nikolay Borisov , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Alyssa Milburn , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com, Greg Kroah-Hartman , Alyssa Milburn Subject: Re: [PATCH v4 1/6] x86/bugs: Add asm helpers for executing VERW Message-ID: <20231220011535.cw3smza3kb5resji@desk> References: <20231027-delay-verw-v4-0-9a3622d4bcf7@linux.intel.com> <20231027-delay-verw-v4-1-9a3622d4bcf7@linux.intel.com> <20231201193657.mvzslo4nlcbuv2q4@treble> <20231201200442.lvyep5uqc6oa7kwj@treble> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201200442.lvyep5uqc6oa7kwj@treble> On Fri, Dec 01, 2023 at 12:04:42PM -0800, Josh Poimboeuf wrote: > On Fri, Dec 01, 2023 at 07:39:05PM +0000, Andrew Cooper wrote: > > On 01/12/2023 7:36 pm, Josh Poimboeuf wrote: > > > On Fri, Oct 27, 2023 at 07:38:40AM -0700, Pawan Gupta wrote: > > >> +.pushsection .entry.text, "ax" > > >> + > > >> +.align L1_CACHE_BYTES, 0xcc > > >> +SYM_CODE_START_NOALIGN(mds_verw_sel) > > >> + UNWIND_HINT_UNDEFINED > > >> + ANNOTATE_NOENDBR > > >> + .word __KERNEL_DS > > >> +.align L1_CACHE_BYTES, 0xcc > > >> +SYM_CODE_END(mds_verw_sel); > > >> +/* For KVM */ > > >> +EXPORT_SYMBOL_GPL(mds_verw_sel); > > >> + > > >> +.popsection > > > This is data, so why is it "CODE" in .entry.text? > > > > Because KPTI. > > Urgh... Pawan please add a comment. Yes, this place needs a comment, will add.