From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E81212E65; Sat, 13 Jan 2024 01:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iOKbQ0TN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EA86C433F1; Sat, 13 Jan 2024 01:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705109959; bh=f+z+aCoBo/R1LCbcJ/n9MFR1O7qF/679Gxl5cb/3qHg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iOKbQ0TNrYHcl5QI2C8ytgTBbYZICCBxplvkmGjmc1SM07yILLF980Ljta5Zubsze Dhag6XvXmcIREpCusq3qVaqlC/OBITak58S+ICjWxG0N9TrgyNHpLkZsY3eoOP6N4Q QRickthm8JPRvfXeoffubHSVucXtyxlwaMTflMIZnpm2XznavfAnk0QPX0K4Nv6Zr8 xpfpTlEBfxYb8qH23h6lY3tgAYyNoXL91IkXDh0bm67NuUOVCjyi1j0l3F6q03xXn+ fqaJz+aE9r2cpqoH1ABqsHNEQ0ZsCMTOfASUFM4K+xrOIqHYNcOo8wrD0YsFTWc1vj ItCDSd/fDh/yA== Date: Fri, 12 Jan 2024 19:39:17 -0600 From: Rob Herring To: Christoph Winklhofer Cc: Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Jiri Slaby , Krzysztof Kozlowski , Jonathan Corbet , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v4 1/3] dt-bindings: w1: UART 1-Wire bus Message-ID: <20240113013917.GA3795949-robh@kernel.org> References: <20240106-w1-uart-v4-0-7fe1378a8b3e@gmail.com> <20240106-w1-uart-v4-1-7fe1378a8b3e@gmail.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240106-w1-uart-v4-1-7fe1378a8b3e@gmail.com> On Sat, Jan 06, 2024 at 05:02:24PM +0100, Christoph Winklhofer wrote: > Add device tree binding for UART 1-Wire bus. > > Signed-off-by: Christoph Winklhofer > --- > Documentation/devicetree/bindings/w1/w1-uart.yaml | 62 +++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > > diff --git a/Documentation/devicetree/bindings/w1/w1-uart.yaml b/Documentation/devicetree/bindings/w1/w1-uart.yaml > new file mode 100644 > index 000000000000..6b90693b2ca0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/w1/w1-uart.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/w1/w1-uart.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: UART 1-Wire Bus > + > +maintainers: > + - Christoph Winklhofer > + > +description: | > + UART 1-wire bus. Utilizes the UART interface via the Serial Device Bus > + to create the 1-Wire timing patterns. > + > + The UART peripheral must support full-duplex and operate in open-drain > + mode. The timing patterns are generated by a specific combination of > + baud-rate and transmitted byte, which corresponds to a 1-Wire read bit, > + write bit or reset pulse. > + > + The default baud-rate for reset and presence detection is 9600 and for > + a 1-Wire read or write operation 115200. In case the actual baud-rate > + is different from the requested one, the transmitted byte is adapted > + to generate the 1-Wire timing patterns. > + > + https://www.analog.com/en/technical-articles/using-a-uart-to-implement-a-1wire-bus-master.html > + > + > +properties: > + compatible: > + const: w1-uart > + > + reset-speed: > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 9600 > + description: | Don't need '|' if no formatting > + The baud rate for the 1-Wire reset and presence detect. > + > + touch_0-speed: Don't use '_' in property names. I'm somewhat familar with 1-wire, but I don't get what 'touch' means here. I assume these are low and high times which are a function of the baudrate. > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 115200 > + description: | > + The baud rate for the 1-Wire write-0 cycle (touch bit 0). > + > + touch_1-speed: > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 115200 > + description: | > + The baud rate for the 1-Wire write-1 and read cycle (touch bit 1). > + > +required: > + - compatible > + > +additionalProperties: false w1.txt says there can be a child node for the 1-wire device. You need 'type: object'. Or w1.txt needs to be converted to schema and referenced here (along with using unevaluatedProperties here instead). Rob