From: "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>
To: "Corona, Ernesto" <ernesto.corona@intel.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"'oleksandrs@mellanox.com'" <oleksandrs@mellanox.com>,
"'jiri@nvidia.com'" <jiri@nvidia.com>,
"Castro, Omar Eduardo" <omar.eduardo.castro@intel.com>,
"'omar.eduardo.castro@linux.intel.com'"
<omar.eduardo.castro@linux.intel.com>,
"'pombredanne@nexb.com'" <pombredanne@nexb.com>,
"'arnd@arndb.de'" <arnd@arndb.de>,
"'bbrezillon@kernel.org'" <bbrezillon@kernel.org>,
"'rdunlap@infradead.org'" <rdunlap@infradead.org>,
"'johan@kernel.org'" <johan@kernel.org>,
"'axboe@kernel.dk'" <axboe@kernel.dk>,
"'joel@jms.id.au'" <joel@jms.id.au>,
"'palmer@sifive.com'" <palmer@sifive.com>,
"'keescook@chromium.org'" <keescook@chromium.org>,
"'vilhelm.gray@gmail.com'" <vilhelm.gray@gmail.com>,
"'federico.vaga@cern.ch'" <federico.vaga@cern.ch>,
"'Jonathan.Cameron@huawei.com'" <Jonathan.Cameron@huawei.com>,
"Luck, Tony" <tony.luck@intel.com>,
"'christian.gromm@microchip.com'" <christian.gromm@microchip.com>,
"'linus.walleij@linaro.org'" <linus.walleij@linaro.org>,
"'zzyiwei@google.com'" <zzyiwei@google.com>,
"'rubini@gnudd.com'" <rubini@gnudd.com>,
"'viresh.kumar@linaro.org'" <viresh.kumar@linaro.org>,
"'mika.westerberg@linux.intel.com'"
<mika.westerberg@linux.intel.com>,
"Filary, Steven A" <steven.a.filary@intel.com>,
"'vadimp@mellanox.com'" <vadimp@mellanox.com>,
"'amithash@fb.com'" <amithash@fb.com>,
"'patrickw3@fb.com'" <patrickw3@fb.com>,
"Chen, Luke" <luke_chen@aspeedtech.com>,
"'billy_tsai@aspeedtech.com'" <billy_tsai@aspeedtech.com>,
"'rgrs@protonmail.com'" <rgrs@protonmail.com>
Subject: Re: [PATCH 30 1/7] Add JTAG core driver
Date: Tue, 30 Jan 2024 15:43:17 -0800 [thread overview]
Message-ID: <2024013039-tractor-subside-4535@gregkh> (raw)
In-Reply-To: <LV8PR11MB846358B901CA67965197C4AB8B7D2@LV8PR11MB8463.namprd11.prod.outlook.com>
On Tue, Jan 30, 2024 at 11:26:19PM +0000, Corona, Ernesto wrote:
> +/**
> + * union pad_config - Padding Configuration:
> + *
> + * @type: transfer type
> + * @pre_pad_number: Number of prepadding bits bit[11:0]
> + * @post_pad_number: Number of prepadding bits bit[23:12]
> + * @pad_data : Bit value to be used by pre and post padding bit[24]
> + * @int_value: unsigned int packed padding configuration value bit[32:0]
> + *
> + * Structure provide pre and post padding configuration in a single __u32
> + */
> +union pad_config {
Bad name for a global structure, don't you think?
> + struct {
> + __u32 pre_pad_number : 12;
> + __u32 post_pad_number : 12;
> + __u32 pad_data : 1;
> + __u32 rsvd : 7;
> + };
This obviously does not work, please don't do that.
thanks,
greg k-h
next prev parent reply other threads:[~2024-01-30 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 23:26 [PATCH 30 1/7] Add JTAG core driver Corona, Ernesto
2024-01-30 23:40 ` 'gregkh@linuxfoundation.org'
2024-01-30 23:43 ` 'gregkh@linuxfoundation.org' [this message]
2024-01-31 10:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024013039-tractor-subside-4535@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=amithash@fb.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bbrezillon@kernel.org \
--cc=billy_tsai@aspeedtech.com \
--cc=christian.gromm@microchip.com \
--cc=ernesto.corona@intel.com \
--cc=federico.vaga@cern.ch \
--cc=jiri@nvidia.com \
--cc=joel@jms.id.au \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke_chen@aspeedtech.com \
--cc=mika.westerberg@linux.intel.com \
--cc=oleksandrs@mellanox.com \
--cc=omar.eduardo.castro@intel.com \
--cc=omar.eduardo.castro@linux.intel.com \
--cc=palmer@sifive.com \
--cc=patrickw3@fb.com \
--cc=pombredanne@nexb.com \
--cc=rdunlap@infradead.org \
--cc=rgrs@protonmail.com \
--cc=rubini@gnudd.com \
--cc=steven.a.filary@intel.com \
--cc=tony.luck@intel.com \
--cc=vadimp@mellanox.com \
--cc=vilhelm.gray@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=zzyiwei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).