From: Dhruva Gole <d-gole@ti.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
andy.shevchenko@gmail.com,
"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
"Philip Howard" <phil@gadgetoid.com>,
"Sean Young" <sean@mess.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH V4 0/2] pwm: Add GPIO PWM driver
Date: Mon, 5 Feb 2024 11:25:14 +0530 [thread overview]
Message-ID: <20240205055514.rox6yd2eenhsngva@dhruva> (raw)
In-Reply-To: <20240204220851.4783-1-wahrenst@gmx.net>
Hi,
On Feb 04, 2024 at 23:08:49 +0100, Stefan Wahren wrote:
> Add a software PWM which toggles a GPIO from a high-resolution timer.
>
> Recent discussions in the Raspberry Pi community revealt that a lot
> of users still use MMIO userspace tools for GPIO access. One argument
> for this approach is the lack of a GPIO PWM kernel driver. So this
> series tries to fill this gap.
>
> This continues the work of Vincent Whitchurch [1], which is easier
> to read and more consequent by rejecting sleeping GPIOs than Nicola's
> approach [2].
>
> The work has been tested on a Raspberry Pi 3 B+ and a cheap logic
> analyzer.
I recently came across this series and I have to say that it will sure be
a nice to have feature to be able to use any GPIO as a PWM.
However, just a minor suggestion is that we should make sure it's well
documented how to actually use this. It would be much appreciated if you
could include some basic documentation of a few sysfs commands or any
userspace library that you used to test what you've mentioned above.
Maybe add another patch for this page?
https://docs.kernel.org/driver-api/pwm.html#using-pwms-with-the-sysfs-interface
This will ensure people know about this feature and will actually be
able to use it.
--
Best regards,
Dhruva Gole <d-gole@ti.com>
next parent reply other threads:[~2024-02-05 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240204220851.4783-1-wahrenst@gmx.net>
2024-02-05 5:55 ` Dhruva Gole [this message]
2024-02-05 7:08 ` [PATCH V4 0/2] pwm: Add GPIO PWM driver Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205055514.rox6yd2eenhsngva@dhruva \
--to=d-gole@ti.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelo.compagnucci@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=phil@gadgetoid.com \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox