From: Elizabeth Figura <zfigura@codeweavers.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
wine-devel@winehq.org, "André Almeida" <andrealmeid@igalia.com>,
"Wolfram Sang" <wsa@kernel.org>,
"Arkadiusz Hiler" <ahiler@codeweavers.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Randy Dunlap" <rdunlap@infradead.org>,
"Elizabeth Figura" <zfigura@codeweavers.com>
Subject: [PATCH v2 17/31] ntsync: Allow waits to use the REALTIME clock.
Date: Mon, 19 Feb 2024 16:38:19 -0600 [thread overview]
Message-ID: <20240219223833.95710-18-zfigura@codeweavers.com> (raw)
In-Reply-To: <20240219223833.95710-1-zfigura@codeweavers.com>
NtWaitForMultipleObjects() can receive a timeout in two forms, relative or
absolute. Relative timeouts are unaffected by changes to the system time and do
not count down while the system suspends; for absolute timeouts the opposite is
true.
In order to make the interface and implementation simpler, the ntsync driver
only deals in absolute timeouts. However, we need to be able to emulate both
behaviours apropos suspension and time adjustment, which is achieved by allowing
either the MONOTONIC or REALTIME clock to be used.
Signed-off-by: Elizabeth Figura <zfigura@codeweavers.com>
---
drivers/misc/ntsync.c | 9 ++++++++-
include/uapi/linux/ntsync.h | 4 ++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
index 0055b4671808..f54c81dada3d 100644
--- a/drivers/misc/ntsync.c
+++ b/drivers/misc/ntsync.c
@@ -778,11 +778,15 @@ static void put_obj(struct ntsync_obj *obj)
static int ntsync_schedule(const struct ntsync_q *q, const struct ntsync_wait_args *args)
{
ktime_t timeout = ns_to_ktime(args->timeout);
+ clockid_t clock = CLOCK_MONOTONIC;
ktime_t *timeout_ptr;
int ret = 0;
timeout_ptr = (args->timeout == U64_MAX ? NULL : &timeout);
+ if (args->flags & NTSYNC_WAIT_REALTIME)
+ clock = CLOCK_REALTIME;
+
do {
if (signal_pending(current)) {
ret = -ERESTARTSYS;
@@ -794,7 +798,7 @@ static int ntsync_schedule(const struct ntsync_q *q, const struct ntsync_wait_ar
ret = 0;
break;
}
- ret = schedule_hrtimeout(timeout_ptr, HRTIMER_MODE_ABS);
+ ret = schedule_hrtimeout_range_clock(timeout_ptr, 0, HRTIMER_MODE_ABS, clock);
} while (ret < 0);
__set_current_state(TASK_RUNNING);
@@ -817,6 +821,9 @@ static int setup_wait(struct ntsync_device *dev,
if (!args->owner)
return -EINVAL;
+ if (args->pad || (args->flags & ~NTSYNC_WAIT_REALTIME))
+ return -EINVAL;
+
if (args->count > NTSYNC_MAX_WAIT_COUNT)
return -EINVAL;
diff --git a/include/uapi/linux/ntsync.h b/include/uapi/linux/ntsync.h
index 555ae81b479a..b5e835d8dba8 100644
--- a/include/uapi/linux/ntsync.h
+++ b/include/uapi/linux/ntsync.h
@@ -28,6 +28,8 @@ struct ntsync_event_args {
__u32 signaled;
};
+#define NTSYNC_WAIT_REALTIME 0x1
+
struct ntsync_wait_args {
__u64 timeout;
__u64 objs;
@@ -35,6 +37,8 @@ struct ntsync_wait_args {
__u32 owner;
__u32 index;
__u32 alert;
+ __u32 flags;
+ __u32 pad;
};
#define NTSYNC_MAX_WAIT_COUNT 64
--
2.43.0
next prev parent reply other threads:[~2024-02-19 22:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 22:38 [PATCH v2 00/31] NT synchronization primitive driver Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 01/31] ntsync: Introduce the ntsync driver and character device Elizabeth Figura
2024-02-22 10:56 ` Geert Uytterhoeven
2024-02-22 20:13 ` Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 02/31] ntsync: Introduce NTSYNC_IOC_CREATE_SEM Elizabeth Figura
2024-03-07 22:12 ` Greg Kroah-Hartman
2024-02-19 22:38 ` [PATCH v2 03/31] ntsync: Introduce NTSYNC_IOC_SEM_POST Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 04/31] ntsync: Introduce NTSYNC_IOC_WAIT_ANY Elizabeth Figura
2024-03-11 18:58 ` Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 05/31] ntsync: Introduce NTSYNC_IOC_WAIT_ALL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 06/31] ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 07/31] ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 08/31] ntsync: Introduce NTSYNC_IOC_MUTEX_KILL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 09/31] ntsync: Introduce NTSYNC_IOC_CREATE_EVENT Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 10/31] ntsync: Introduce NTSYNC_IOC_EVENT_SET Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 11/31] ntsync: Introduce NTSYNC_IOC_EVENT_RESET Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 12/31] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 13/31] ntsync: Introduce NTSYNC_IOC_SEM_READ Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 14/31] ntsync: Introduce NTSYNC_IOC_MUTEX_READ Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 15/31] ntsync: Introduce NTSYNC_IOC_EVENT_READ Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 16/31] ntsync: Introduce alertable waits Elizabeth Figura
2024-02-19 22:38 ` Elizabeth Figura [this message]
2024-02-20 7:01 ` [PATCH v2 17/31] ntsync: Allow waits to use the REALTIME clock Arnd Bergmann
2024-02-22 0:48 ` Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 18/31] selftests: ntsync: Add some tests for semaphore state Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 19/31] selftests: ntsync: Add some tests for mutex state Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 20/31] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 21/31] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 22/31] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 23/31] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 24/31] selftests: ntsync: Add some tests for manual-reset event state Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 25/31] selftests: ntsync: Add some tests for auto-reset " Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 26/31] selftests: ntsync: Add some tests for wakeup signaling with events Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 27/31] selftests: ntsync: Add tests for alertable waits Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 28/31] selftests: ntsync: Add some tests for wakeup signaling via alerts Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 29/31] selftests: ntsync: Add a stress test for contended waits Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 30/31] maintainers: Add an entry for ntsync Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 31/31] docs: ntsync: Add documentation for the ntsync uAPI Elizabeth Figura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219223833.95710-18-zfigura@codeweavers.com \
--to=zfigura@codeweavers.com \
--cc=ahiler@codeweavers.com \
--cc=andrealmeid@igalia.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=shuah@kernel.org \
--cc=wine-devel@winehq.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).