From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F7B7EEE6; Mon, 26 Feb 2024 12:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708950862; cv=none; b=MjZdVPezxQaTtTENoOcjYqrmGX/cBdibmnv/+yhllKVHonupDH+lF/lU/GxSFztU4w0dXkjs2HaCFw/G/tX4TKSeY/DMKqDsXWxbpvaLTXF7mkR0zpzXlEU/QTuQ0uUkY0IRKf7jWcF35XEPoSiY27MiulwuZUm8ygbEGUduCcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708950862; c=relaxed/simple; bh=dbszWLDjXPJNwXKH/pEp8OApSBuWz+lKi4U/CYmXC1s=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oCVQDkDRpMp/Uw6Sotdpd/JEo4uHozwS3nCgs0DUTpqisbgMYikUaR27XqBwUJABgYHFTMSibcAyTeSg7sj9GcSIdwDMumOZVWbM1Ws3fbXCkBc1M3KC+WtpGUMI8MPUcvWdyw/nbqilnReajFnP7Plan67PzsJ88hDHjbro0gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Tk0Lb3cwgz6K6j5; Mon, 26 Feb 2024 20:29:59 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 079E01411DE; Mon, 26 Feb 2024 20:34:18 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 26 Feb 2024 12:34:17 +0000 Date: Mon, 26 Feb 2024 12:34:16 +0000 From: Jonathan Cameron To: John Groves CC: John Groves , Jonathan Corbet , "Dan Williams" , Vishal Verma , Dave Jiang , "Alexander Viro" , Christian Brauner , "Jan Kara" , Matthew Wilcox , , , , , , , Dave Chinner , Christoph Hellwig , , Subject: Re: [RFC PATCH 06/20] dev_dax_iomap: Add CONFIG_DEV_DAX_IOMAP kernel build parameter Message-ID: <20240226123416.0000200f@Huawei.com> In-Reply-To: <13365680ad42ba718c36b90165c56c3db43e8fdf.1708709155.git.john@groves.net> References: <13365680ad42ba718c36b90165c56c3db43e8fdf.1708709155.git.john@groves.net> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) On Fri, 23 Feb 2024 11:41:50 -0600 John Groves wrote: > Add the CONFIG_DEV_DAX_IOMAP kernel config parameter to control building > of the iomap functionality to support fsdax on devdax. I would squash with previous patch. Only reason I ever see for separate Kconfig patches is when there is something complex in the dependencies and you want to talk about it in depth in the patch description. That's not true here so no need for separate patch. > > Signed-off-by: John Groves > --- > drivers/dax/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig > index a88744244149..b1ebcc77120b 100644 > --- a/drivers/dax/Kconfig > +++ b/drivers/dax/Kconfig > @@ -78,4 +78,10 @@ config DEV_DAX_KMEM > > Say N if unsure. > > +config DEV_DAX_IOMAP > + depends on DEV_DAX && DAX > + def_bool y > + help > + Support iomap mapping of devdax devices (for FS-DAX file > + systems that reside on character /dev/dax devices) > endif