From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Laight <David.Laight@aculab.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Martin Uecker <Martin.Uecker@med.uni-goettingen.de>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] compiler.h: Explain how __is_constexpr() works
Date: Fri, 1 Mar 2024 17:46:55 -0800 [thread overview]
Message-ID: <202403011745.C9851C46@keescook> (raw)
In-Reply-To: <ZeJ-LAkSxwBlr9_v@surfacebook.localdomain>
On Sat, Mar 02, 2024 at 03:17:32AM +0200, Andy Shevchenko wrote:
> Thu, Feb 29, 2024 at 08:44:37PM -0800, Kees Cook kirjoitti:
> > The __is_constexpr() macro is dark magic. Shed some light on it with
> > a comment to explain how and why it works.
>
> I was under impression that somebody did it already once and it fell through
> cracks when has been moved (?) to compiler.h.
I tried to do it before (see the v1).
>
> Ah, now I see it, https://lore.kernel.org/all/YKeghxRY4FeOKuwb@smile.fi.intel.com/.
> It was asked, but till now never fulfilled (maybe Reported-by:/Closes: tag?).
Sure! akpm was hardly the first to ask about it, but yeah, makes for
some good tags.
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Closes: https://lore.kernel.org/all/20210520134112.ee15f156f1b7dbd3d8f16471@linux-foundation.org/
:)
> And explanation before was given here:
> https://stackoverflow.com/questions/49481217/linux-kernels-is-constexpr-macro.
Sure, but I wanted something that lived with the macro and everyone was
happy with the details.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2024-03-02 1:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 4:44 [PATCH] compiler.h: Explain how __is_constexpr() works Kees Cook
2024-03-01 8:16 ` Jani Nikula
2024-03-01 9:32 ` David Laight
2024-03-01 13:21 ` [+externe Mail+] " Uecker, Martin
2024-03-01 13:43 ` David Laight
2024-03-01 13:56 ` Uecker, Martin
2024-03-02 1:17 ` Andy Shevchenko
2024-03-02 1:46 ` Kees Cook [this message]
2024-03-04 16:52 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403011745.C9851C46@keescook \
--to=keescook@chromium.org \
--cc=David.Laight@aculab.com \
--cc=Martin.Uecker@med.uni-goettingen.de \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=gustavoars@kernel.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).