Re: [PATCH net-next v3 12/12] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY

Andrew Lunn
2024-03-06T18:48:42Z

> > +description:
> > + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet
> > + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller
> > + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible
> > + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver
> > + integrated into the LAN8650/1. The communication between the Host and
> > + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial
> > + Interface (TC6).
> > +
> > +allOf:
> > + - $ref: ethernet-controller.yaml#
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - const: microchip,lan8650
> > + - const: microchip,lan8651
>
> The order here is wrong, lan8561 needs to come before the fallback of
> lan8650.

I don't think it is a fallback. There are two devices, and hence two
different compatibles. So i suspect the -items: is wrong here?

Andrew