Re: [PATCH net-next v3 04/12] net: ethernet: oa_tc6: implement software reset

Parthiban.Veerasooran
2024-03-08T08:25:36Z

Hi Andrew,

On 07/03/24 6:54 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>>>> +static int oa_tc6_read_sw_reset_status(struct oa_tc6 *tc6)
>>>> +{
>>>> + u32 regval;
>>>> + int ret;
>>>> +
>>>> + ret = oa_tc6_read_register(tc6, OA_TC6_REG_STATUS0, &regval);
>>>> + if (ret)
>>>> + return 0;
>>>> +
>>>> + return regval;
>>>
>>> The function name does not really fit what the function does. The
>>> function returns OA_TC6_REG_STATUS0. I assume it has more bits in it
>>> than just STATUS0_RESETC. So either this function should be called
>>> oa_tc6_read_status0, or you should mask regval with STATUS0_RESETC, so
>>> that it does actually return the sw reset status.
>> Ok, as we do the masking in the calling function readx_poll_timeout, as
>> you suggested I will change the function name as oa_tc6_read_status0 in
>> the next version.
>
> O.K. And i think some of the later patches can them make use of this
> generic function.
Yes, might be helpful.

Best regards,
Parthiban V
>
> Andrew