Re: [PATCH net-next v3 09/12] net: ethernet: oa_tc6: implement receive path to receive rx ethernet frames

Andrew Lunn
2024-03-19T13:20:41Z

On Tue, Mar 19, 2024 at 12:54:34PM +0000, Parthiban.Veerasooran@microchip.com wrote:
> Hi Andrew,
>
> On 08/03/24 5:44 am, Andrew Lunn wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> >> +static int oa_tc6_allocate_rx_skb(struct oa_tc6 *tc6)
> >> +{
> >> + tc6->rx_skb = netdev_alloc_skb(tc6->netdev, tc6->netdev->mtu + ETH_HLEN +
> >> + ETH_FCS_LEN + NET_IP_ALIGN);
> >> + if (!tc6->rx_skb) {
> >> + tc6->netdev->stats.rx_dropped++;
> >> + netdev_err(tc6->netdev, "Out of memory for rx'd frame");
> >
> > If that happens, it is not something which will fix itself quickly. So
> > you are likely to spam the logs. The counter on its own is probably
> > enough.
> Ok, then don't we need to convey this info in the dmesg to the user. For
> that shall we use net_err_ratelimited() instead of netdev_err()? Or we
> don't need any print at all?

I would not print anything at all.

Andrew