Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking

Parthiban.Veerasooran
2024-03-07T08:29:04Z

Hi Andrew,

On 07/03/24 6:13 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, Mar 06, 2024 at 02:20:10PM +0530, Parthiban Veerasooran wrote:
>> This will unmask the following error interrupts from the MAC-PHY.
>> tx protocol error
>> rx buffer overflow error
>> loss of frame error
>
> The standard seems to call it "Loss of framing". To me as a network
> person, a frame is an L2 Ethernet packet. However, framing is
> something completely different, being able to synchronise a bitstream
> with some sort of markers, e.g. E1 to know where the 32 slots are.
>
> In this context, we are not talking about packets, but the SPI bit
> stream. So it would be good to use framing, not frame.
Yes you are right. The specification also says the same thing as you
said "Loss of Framing Error". I will correct it in the next version.

Best regards,
Parthiban V
>
> Andrew
>