From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: robh@kernel.org, steven.price@arm.com, airlied@gmail.com,
daniel@ffwll.ch, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, corbet@lwn.net,
kernel@collabora.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 1/1] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs
Date: Mon, 11 Mar 2024 11:00:27 +0100 [thread overview]
Message-ID: <20240311110027.34b8b616@collabora.com> (raw)
In-Reply-To: <20240306015819.822128-2-adrian.larumbe@collabora.com>
On Wed, 6 Mar 2024 01:56:36 +0000
Adrián Larumbe <adrian.larumbe@collabora.com> wrote:
>
> +static ssize_t profiling_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct panfrost_device *pfdev = dev_get_drvdata(dev);
> +
> + return sysfs_emit(buf, "%d\n", pfdev->profile_mode);
> +}
> +
> +
Dropped the extra blank and queued the patch to drm-misc-next.
> +static ssize_t profiling_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t len)
> +{
> + struct panfrost_device *pfdev = dev_get_drvdata(dev);
> + bool value;
> + int err;
> +
> + err = kstrtobool(buf, &value);
> + if (err)
> + return err;
> +
> + pfdev->profile_mode = value;
> +
> + return len;
> +}
prev parent reply other threads:[~2024-03-11 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 1:56 [PATCH v3 0/1] drm/panfrost: Replace fdinfo's profiling debugfs knob Adrián Larumbe
2024-03-06 1:56 ` [PATCH v3 1/1] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs Adrián Larumbe
2024-03-06 8:33 ` Tvrtko Ursulin
2024-03-11 10:02 ` Boris Brezillon
2024-03-12 0:47 ` Adrián Larumbe
2024-03-06 8:41 ` Boris Brezillon
2024-03-06 14:31 ` Steven Price
2024-03-11 10:00 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311110027.34b8b616@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).