From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8EEF1DFF2; Thu, 28 Mar 2024 13:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711633919; cv=none; b=roBjaAxp2ZiJ6XxxXm7OqnwA7l4LlSewfpT3eAVb2MSgxbUdaBW7OqwnFSFmsQdzcQ38qTZFQzuVdK96hqTxeAZkV7UfahB/4ndjVEouANuZfCbetLz67of9rvqh2xQLZSnwB1uR/M0HQVmXD5seCI/+44pyAfA2qI//Oaj3zpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711633919; c=relaxed/simple; bh=26u9hTutRX6gyzhSopBxvNqZnd9SNWQgRgZYdO/+yxg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sUiiKJa7Zv35vxZa/FVhUU3mf3+TcA6AQe+THtoOzyXK1nZQ1TXJPmMZdpoTuuTLlSv/tmNJG3zP463QnzkKfjCpYG0Djqm9BPUmSCHBiN5TeFr90FIIemgIAUZ0+GBDT592ByRlif3L6h3gEzboIfNB0uZfKjA+KrQbPN8u2YI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iZ7l3BC4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iZ7l3BC4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5365CC433F1; Thu, 28 Mar 2024 13:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711633919; bh=26u9hTutRX6gyzhSopBxvNqZnd9SNWQgRgZYdO/+yxg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iZ7l3BC4RFLFjfD958z/Um8CFZJv87cNlRlI2Q68ynNI5q3ZWgso7zPVIi8TTsRbt x6ltTKqlH2ezgVxYqJdyHkgsf3MxwjsbzY8Ttwd7n232+ILqpSgEwThJ0XU3CVwOFb mG7lC9MPSEO74lcIJYE2eCCZkUP0h1DYU0Bl/rqN4RSdxlIO+JzDoCLfuC+MbsO0tr ERVYr0LkSOIGAwM+idaDlpuCOpkMbbaGnYUXbgoi9Q1jsn+Rvs2UVOGVfszjPb+9Ge 4KXetUBFBwBr4n8KynzSYgedrrPXwmCfKyXZzl5hrWyQpIePoh9+k4zzeySti9Pe8R I2knuWsLWI3bg== Date: Thu, 28 Mar 2024 13:51:40 +0000 From: Jonathan Cameron To: David Lechner Cc: Jonathan Corbet , Liam Girdwood , Mark Brown , Jean Delvare , Guenter Roeck , Support Opensource , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Greg Kroah-Hartman , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-input@vger.kernel.org Subject: Re: [PATCH RFC 5/7] iio: frequency: admv1013: Use devm_regulator_get_enable_get_voltage() Message-ID: <20240328135140.7cb91163@jic23-huawei> In-Reply-To: <20240327-regulator-get-enable-get-votlage-v1-5-5f4517faa059@baylibre.com> References: <20240327-regulator-get-enable-get-votlage-v1-0-5f4517faa059@baylibre.com> <20240327-regulator-get-enable-get-votlage-v1-5-5f4517faa059@baylibre.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 18:18:54 -0500 David Lechner wrote: > We can reduce boilerplate code by using > devm_regulator_get_enable_get_voltage(). > > The common mode voltage is now passed as a parameter in the init > functions so we can avoid adding a state member that is only used > during init. > > Signed-off-by: David Lechner LGTM - on basis this might not go through my tree Reviewed-by: Jonathan Cameron