From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2EF612B71; Wed, 1 May 2024 02:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714531031; cv=none; b=qSRMbLbgXOL028sfu8xP9upYlkATlEoFYxDGzerN+RBJ+7EhX8ix10cwbCBZElXReJORJ5XqXBRxIp4NP5mGFDSmuzGdVD7jP3JjvObsHB0afVpC/fovKcR3uS3wb5Mlv2bYga7dxz/v23Qzx+mxPvRacBj9CXAO/XFC1L0zPYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714531031; c=relaxed/simple; bh=y8xLAXNr+/UtvDDmPpBQLJYvsR7p4WubKvcI9fxnIfI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NmLiujCLsbjx1HzdidE6TqeqimcWWXjQ1jhcX5gYPDsW/TVtU2qmW4yVgRaRv1RYZgnweWKBulFOVNFNJxga/Ojk9AKO8mL2x2dF8LVmu9jFlGda3BkAwAI6ZWyUSyf60dWEWB1dmxoBKOe7nrfyrsyLluBCBqgeTxcXpNo6Clg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S9M4Leat; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S9M4Leat" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714531029; x=1746067029; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=y8xLAXNr+/UtvDDmPpBQLJYvsR7p4WubKvcI9fxnIfI=; b=S9M4Leat2R7QqYh5pG2QRL0fvKA/Wf4XwxTQzjMVl4cypoVHcAjwxDG8 FG2akOUxtXI+E3KT+MkiK3O5oR/Hapt2ioIOhbIWbOQcvvSq7wuukhrKu aEvvl6qvhFBTYzyCVJX2j/c6CY7y5pejD5QaRtG4QehMAzYOnLOEd2UaR FaLpt6b/U4dOWgfloh//HGcz7yR70kOFp7ODtXURMnJAUH1GC7ULJc64O a3UUQsElJtFXZUCV7nOxGAHOzn+MwiJDPcHuRZ0Bb/uooTSrZsNjUrDQ5 J+7Ow1gEkRdPyNh6HbgZH3hzZPeBZ7IjI2rEh0KKFnfDs8/BOPdWBgoo4 A==; X-CSE-ConnectionGUID: gRdvClOhQ7qjFPf6BiwZ0w== X-CSE-MsgGUID: 0pS1k+UZRna6fK8m7NeVIA== X-IronPort-AV: E=McAfee;i="6600,9927,11060"; a="21667446" X-IronPort-AV: E=Sophos;i="6.07,244,1708416000"; d="scan'208";a="21667446" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2024 19:37:08 -0700 X-CSE-ConnectionGUID: snhREbvBShugyaqUCOG16g== X-CSE-MsgGUID: dSeqwmzwQSWWNDOuad4Y2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,244,1708416000"; d="scan'208";a="31132294" Received: from lkp-server01.sh.intel.com (HELO e434dd42e5a1) ([10.239.97.150]) by fmviesa005.fm.intel.com with ESMTP; 30 Apr 2024 19:37:02 -0700 Received: from kbuild by e434dd42e5a1 with local (Exim 4.96) (envelope-from ) id 1s1zq8-0008lj-0u; Wed, 01 May 2024 02:37:00 +0000 Date: Wed, 1 May 2024 10:36:03 +0800 From: kernel test robot To: Heng Qi , netdev@vger.kernel.org, virtualization@lists.linux.dev Cc: oe-kbuild-all@lists.linux.dev, Jakub Kicinski , "David S . Miller" , Paolo Abeni , Eric Dumazet , Jason Wang , "Michael S . Tsirkin" , Brett Creeley , Ratheesh Kannoth , Alexander Lobakin , Xuan Zhuo , Tal Gilboa , Jonathan Corbet , linux-doc@vger.kernel.org, Maxime Chevallier , Jiri Pirko , Paul Greenwalt , Ahmed Zaki , Vladimir Oltean , Kory Maincent , Andrew Lunn , justinstitt@google.com Subject: Re: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management Message-ID: <202405011004.Rkw6IrSl-lkp@intel.com> References: <20240430173136.15807-3-hengqi@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240430173136.15807-3-hengqi@linux.alibaba.com> Hi Heng, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/linux-dim-move-useful-macros-to-h-file/20240501-013413 base: net-next/main patch link: https://lore.kernel.org/r/20240430173136.15807-3-hengqi%40linux.alibaba.com patch subject: [PATCH net-next v11 2/4] ethtool: provide customized dim profile management config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240501/202405011004.Rkw6IrSl-lkp@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405011004.Rkw6IrSl-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405011004.Rkw6IrSl-lkp@intel.com/ All warnings (new ones prefixed by >>): net/ethtool/coalesce.c: In function 'ethnl_update_profile': net/ethtool/coalesce.c:453:46: error: 'struct net_device' has no member named 'irq_moder' 453 | struct dim_irq_moder *irq_moder = dev->irq_moder; | ^~ net/ethtool/coalesce.c: At top level: >> net/ethtool/coalesce.c:446:12: warning: 'ethnl_update_profile' defined but not used [-Wunused-function] 446 | static int ethnl_update_profile(struct net_device *dev, | ^~~~~~~~~~~~~~~~~~~~ >> net/ethtool/coalesce.c:151:12: warning: 'coalesce_put_profile' defined but not used [-Wunused-function] 151 | static int coalesce_put_profile(struct sk_buff *skb, u16 attr_type, | ^~~~~~~~~~~~~~~~~~~~ vim +/ethnl_update_profile +446 net/ethtool/coalesce.c 424 425 /** 426 * ethnl_update_profile - get a profile nest with child nests from userspace. 427 * @dev: netdevice to update the profile 428 * @dst: profile get from the driver and modified by ethnl_update_profile. 429 * @nests: nest attr ETHTOOL_A_COALESCE_*X_PROFILE to set profile. 430 * @extack: Netlink extended ack 431 * 432 * Layout of nests: 433 * Nested ETHTOOL_A_COALESCE_*X_PROFILE attr 434 * Nested ETHTOOL_A_PROFILE_IRQ_MODERATION attr 435 * ETHTOOL_A_IRQ_MODERATION_USEC attr 436 * ETHTOOL_A_IRQ_MODERATION_PKTS attr 437 * ETHTOOL_A_IRQ_MODERATION_COMPS attr 438 * ... 439 * Nested ETHTOOL_A_PROFILE_IRQ_MODERATION attr 440 * ETHTOOL_A_IRQ_MODERATION_USEC attr 441 * ETHTOOL_A_IRQ_MODERATION_PKTS attr 442 * ETHTOOL_A_IRQ_MODERATION_COMPS attr 443 * 444 * Return: 0 on success or a negative error code. 445 */ > 446 static int ethnl_update_profile(struct net_device *dev, 447 struct dim_cq_moder __rcu **dst, 448 const struct nlattr *nests, 449 struct netlink_ext_ack *extack) 450 { 451 int len_irq_moder = ARRAY_SIZE(coalesce_irq_moderation_policy); 452 struct nlattr *tb[ARRAY_SIZE(coalesce_irq_moderation_policy)]; > 453 struct dim_irq_moder *irq_moder = dev->irq_moder; 454 struct dim_cq_moder *new_profile, *old_profile; 455 int ret, rem, i = 0, len; 456 struct nlattr *nest; 457 458 if (!nests) 459 return 0; 460 461 if (!*dst) 462 return -EOPNOTSUPP; 463 464 old_profile = rtnl_dereference(*dst); 465 len = NET_DIM_PARAMS_NUM_PROFILES * sizeof(*old_profile); 466 new_profile = kmemdup(old_profile, len, GFP_KERNEL); 467 if (!new_profile) 468 return -ENOMEM; 469 470 nla_for_each_nested_type(nest, ETHTOOL_A_PROFILE_IRQ_MODERATION, 471 nests, rem) { 472 ret = nla_parse_nested(tb, len_irq_moder - 1, nest, 473 coalesce_irq_moderation_policy, 474 extack); 475 if (ret) 476 goto err_out; 477 478 ret = ethnl_update_irq_moder(irq_moder, &new_profile[i].usec, 479 ETHTOOL_A_IRQ_MODERATION_USEC, 480 tb, DIM_COALESCE_USEC, 481 extack); 482 if (ret) 483 goto err_out; 484 485 ret = ethnl_update_irq_moder(irq_moder, &new_profile[i].pkts, 486 ETHTOOL_A_IRQ_MODERATION_PKTS, 487 tb, DIM_COALESCE_PKTS, 488 extack); 489 if (ret) 490 goto err_out; 491 492 ret = ethnl_update_irq_moder(irq_moder, &new_profile[i].comps, 493 ETHTOOL_A_IRQ_MODERATION_COMPS, 494 tb, DIM_COALESCE_COMPS, 495 extack); 496 if (ret) 497 goto err_out; 498 499 i++; 500 } 501 502 rcu_assign_pointer(*dst, new_profile); 503 kfree_rcu(old_profile, rcu); 504 505 return 0; 506 507 err_out: 508 kfree(new_profile); 509 return ret; 510 } 511 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki