From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EB301E481 for ; Tue, 14 May 2024 16:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715705901; cv=none; b=kSNDeROaMJ9QU0RFyPtxVE0pT8WDfqxUTcOCxDRMRw/B5jtMlWAML7LPHdesf4uR8UKi5/1rCbZZA7KRtjdDyk+Pb5lbDJxMserqaLEX6uXeK4S6B0oO61BhaZcJC7ulM0rdkO5h/IQf4CI4IsHdC8/ci93hlWjrx0SPOZVRy+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715705901; c=relaxed/simple; bh=UXuR92VhqJBzfoNeRxmO5MOMML/qDveLP+5yOuN5TKo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ioC/Z7W8BCfrYubD+I+whiwqQ3Tgpqr8cgj4ZEhfzGGUVj28uoInafgjW9DJV5K0AYK3EV2EVLO+JYsrQbALvh5GQ15V1B1qLpxhFhiSavRdlORPKgS78NSVL+yiXedmqP8ZMtmZW9jJNftt15WB4T3yKSIl+a5lUvZrQZ73QmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=hjZRKD+o; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hjZRKD+o" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e3c3aa8938so40206855ad.1 for ; Tue, 14 May 2024 09:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715705900; x=1716310700; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wEkF4iBhBtaf00+75FpppIRiafT1boFmdAFNfkJUL48=; b=hjZRKD+oOLrNxLdv7ZBO2stWMNuariV9mWueLYo0xYB5J4bpHLDFZCuDaCz0x67Q4c lwlJeyV8i7wNlg9yAK0Hg4PYLa58xHazUOIeEm2JrMsKkjiWZ2P2qTRcbuoZC4KeLmbq lQIAzNdom4U+CDmc6cPv0vMSEem1etxRqlOFE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715705900; x=1716310700; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wEkF4iBhBtaf00+75FpppIRiafT1boFmdAFNfkJUL48=; b=iIoEJKVJHyv2UVW+m69adrno7ZEo/GpDL/Id4/B7qN9vBfrWi8TuMu1QehuSykE1Ao OTpGd97VKiI0At6ah6VpDUWAY8PY8MkGFtngyIT4OnZppfeWsYWwfEs4aseBVffS7afz FBfjbdjO1+hTqJCkfEKCvKebg55eDlftXFDNIyBZXRmQ4gh1p0EdqxIiDeKuVhsxC6ch ziu23wbrqBF53qkeOc1vI+DkXtVG6E/1t1/OhH3SJ6frVUw9SSm2efmwHwXIefQYSXy6 plRAjDsXRINql0bJVOEJvroEcMJfzicIJIhflBiIS+Hc7ecx14G7axbIIqTYisbtbbGN ntyg== X-Forwarded-Encrypted: i=1; AJvYcCUD7dtfLtSbgfqBs5+8CdvDoqgKnvYnlTga7LfRVITJa+pXgDM6U2lOUMc1gzBTyGIUdSwwzzms+1lFUhRLfpHCHhxZXSN8jTss X-Gm-Message-State: AOJu0YxDVwy2vBCWNt7aJy4By+gNMVqYNIozssqkBsS0VBRK/Zu9AE6V +QqkKODz6qGCO19eHHLzhPMpekdweyUdsE6IPFvipF3FSZ7ZCYpkOkQj5HSpgQ== X-Google-Smtp-Source: AGHT+IFx8txCf+f4PDg/JkVSx/NTLN/wTj1FanyAGcZfdZBY3c1JiC6zHAzNid2BkAx76LnPYKzB7A== X-Received: by 2002:a17:902:e887:b0:1eb:7d1d:67d7 with SMTP id d9443c01a7336-1ef43c0fda8mr180003195ad.3.1715705899703; Tue, 14 May 2024 09:58:19 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d4278sm102727825ad.12.2024.05.14.09.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 09:58:19 -0700 (PDT) Date: Tue, 14 May 2024 09:58:18 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, pasha.tatashin@soleen.com, vbabka@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] lib: add version into /proc/allocinfo output Message-ID: <202405140957.92089A615@keescook> References: <20240514163128.3662251-1-surenb@google.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240514163128.3662251-1-surenb@google.com> On Tue, May 14, 2024 at 09:31:28AM -0700, Suren Baghdasaryan wrote: > Add version string and a header at the beginning of /proc/allocinfo to > allow later format changes. Example output: > > > head /proc/allocinfo > allocinfo - version: 1.0 > # > 0 0 init/main.c:1314 func:do_initcalls > 0 0 init/do_mounts.c:353 func:mount_nodev_root > 0 0 init/do_mounts.c:187 func:mount_root_generic > 0 0 init/do_mounts.c:158 func:do_mount_root > 0 0 init/initramfs.c:493 func:unpack_to_rootfs > 0 0 init/initramfs.c:492 func:unpack_to_rootfs > 0 0 init/initramfs.c:491 func:unpack_to_rootfs > 512 1 arch/x86/events/rapl.c:681 func:init_rapl_pmus > 128 1 arch/x86/events/rapl.c:571 func:rapl_cpu_online > > Signed-off-by: Suren Baghdasaryan Ah yeah, good idea. (Do we have versioning like this anywhere else in our /proc files? It seems a nice thing to add...) Reviewed-by: Kees Cook -- Kees Cook