From: Kory Maincent <kory.maincent@bootlin.com>
To: Sai Krishna Gajula <saikrishnag@marvell.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [PATCH net-next v13 12/14] net: ptp: Move ptp_clock_index() to builtin symbol
Date: Thu, 30 May 2024 14:53:50 +0200 [thread overview]
Message-ID: <20240530145350.6341746f@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <BY3PR18MB47074528CBB38F55A3F58A19A0F32@BY3PR18MB4707.namprd18.prod.outlook.com>
Hello Sai,
On Thu, 30 May 2024 11:23:10 +0000
Sai Krishna Gajula <saikrishnag@marvell.com> wrote:
> > Move ptp_clock_index() to builtin symbols to prepare for supporting get and
> > set hardware timestamps from ethtool, which is builtin.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > }
> > +
> > +int ptp_clock_index(struct ptp_clock *ptp) {
> > + return ptp->index;
> > +}
> > +EXPORT_SYMBOL(ptp_clock_index);
> >
> Please check the "build_clang - FAILED", "build_32bit - FAILED" build errors.
Could you be more explicit? Which config are you using?
What is the build error?
I don't really see how this patch can bring a 32bit or clang build error.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-05-30 12:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 9:39 [PATCH net-next v13 00/14] net: Make timestamping selectable Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 01/14] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 02/14] net: Move dev_set_hwtstamp_phylib to net/core/dev.h Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 03/14] net: Make dev_get_hwtstamp_phylib accessible Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 04/14] net: Make net_hwtstamp_validate accessible Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 05/14] net: Change the API of PHY default timestamp to MAC Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 06/14] net: net_tstamp: Add unspec field to hwtstamp_source enumeration Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 07/14] net: Add struct kernel_ethtool_ts_info Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 08/14] ptp: Add phc source and helpers to register specific PTP clock or get information Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 09/14] net: Add the possibility to support a selected hwtstamp in netdevice Kory Maincent
2024-05-29 15:21 ` Jakub Kicinski
2024-05-29 15:50 ` Kory Maincent
2024-05-29 16:05 ` Thomas Petazzoni
2024-05-30 8:39 ` Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 10/14] net: netdevsim: ptp_mock: Convert to netdev_ptp_clock_register Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 11/14] net: macb: " Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 12/14] net: ptp: Move ptp_clock_index() to builtin symbol Kory Maincent
2024-05-30 11:23 ` Sai Krishna Gajula
2024-05-30 12:53 ` Kory Maincent [this message]
2024-05-30 15:45 ` Jakub Kicinski
2024-05-29 9:39 ` [PATCH net-next v13 13/14] net: ethtool: tsinfo: Add support for hwtstamp provider and get/set hwtstamp config Kory Maincent
2024-05-29 9:39 ` [PATCH net-next v13 14/14] netlink: specs: tsinfo: Enhance netlink attributes and add a set command Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530145350.6341746f@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saikrishnag@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox