From: Lee Jones <lee@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Vinod Koul" <vkoul@kernel.org>,
lkp@intel.com, linux-iio@vger.kernel.org,
dmaengine@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
"Paul Cercueil" <paul@crapouillou.net>,
"Nuno Sá" <nuno.sa@analog.com>,
"Christian König" <christian.koenig@amd.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
oe-kbuild-all@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
"Julia Lawall" <julia.lawall@inria.fr>,
"Randy Dunlap" <rdunlap@infradead.org>
Subject: Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure
Date: Fri, 21 Jun 2024 08:51:23 +0100 [thread overview]
Message-ID: <20240621075123.GG1318296@google.com> (raw)
In-Reply-To: <ebddd644-b9b1-4a87-a2e7-dcf255f4184d@web.de>
On Fri, 21 Jun 2024, Markus Elfring wrote:
> > Sadly, I am yet to see a constructive approach or even better a helpful
> > patch which improve something, rather than vague suggestions on the list
>
> Can you get any more constructive impressions from another data representation?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=author&q=Elfring
>
> Are you aware how many change suggestions (also from my selection) are still
> in various waiting queues?
No one is doubting your overall contributions Markus.
The issue is one of communication and the way reviews are conducted.
Reviewing other people's work is challenging and requires a certain
skill-set, of which _excellent_ communication skills are non-negotiable.
Why not concentrate on more complex submissions for a while and grow
your repertoire of common review points, rather than repeating the same
few over and over? Reading other, more experienced maintainer's reviews
would also be a good use of your time.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-21 7:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 10:02 [PATCH v11 0/7] iio: new DMABUF based API v11 Paul Cercueil
2024-06-18 10:02 ` [PATCH v11 1/7] dmaengine: Add API function dmaengine_prep_peripheral_dma_vec() Paul Cercueil
2024-06-18 10:02 ` [PATCH v11 2/7] dmaengine: dma-axi-dmac: Implement device_prep_peripheral_dma_vec Paul Cercueil
2024-06-18 10:02 ` [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure Paul Cercueil
2024-06-19 3:15 ` kernel test robot
2024-06-19 5:57 ` Nuno Sá
2024-06-19 10:03 ` [v11 " Markus Elfring
2024-06-19 10:09 ` Paul Cercueil
2024-06-19 11:13 ` Markus Elfring
2024-06-19 11:30 ` Paul Cercueil
2024-06-19 11:56 ` Markus Elfring
2024-06-19 12:21 ` Paul Cercueil
2024-06-19 12:42 ` Nuno Sá
2024-06-20 10:45 ` Markus Elfring
2024-06-20 16:09 ` Vinod Koul
2024-06-20 17:05 ` Lee Jones
2024-06-21 7:09 ` Vinod Koul
2024-06-21 7:18 ` Nuno Sá
2024-06-21 7:36 ` Markus Elfring
2024-06-21 7:44 ` Lee Jones
2024-06-21 7:27 ` Markus Elfring
2024-06-21 7:51 ` Lee Jones [this message]
2024-06-21 8:10 ` [RFC] Patch review challenges Markus Elfring
2024-06-21 8:21 ` Lee Jones
2024-06-19 11:43 ` [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure Markus Elfring
2024-06-19 12:16 ` Paul Cercueil
2024-06-19 13:28 ` Markus Elfring
2024-06-18 10:02 ` [PATCH v11 4/7] iio: buffer-dma: Enable support for DMABUFs Paul Cercueil
2024-06-18 10:03 ` [PATCH v11 5/7] iio: buffer-dmaengine: Support new DMABUF based userspace API Paul Cercueil
2024-06-18 10:03 ` [PATCH v11 6/7] Documentation: iio: Document high-speed DMABUF based API Paul Cercueil
2024-06-19 12:22 ` Bagas Sanjaya
2024-06-18 10:03 ` [PATCH v11 7/7] Documentation: dmaengine: Document new dma_vec API Paul Cercueil
2024-06-19 12:34 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621075123.GG1318296@google.com \
--to=lee@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jic23@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=lars@metafoo.de \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paul@crapouillou.net \
--cc=rdunlap@infradead.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).