Re: [RFC] Patch review challenges

[Lee Jones <lee@kernel.org>]

On Fri, 21 Jun 2024, Markus Elfring wrote:

> > The issue is one of communication and the way reviews are conducted.
> >
> > Reviewing other people's work is challenging and requires a certain
> > skill-set, of which _excellent_ communication skills are non-negotiable.
> 
> Patch feedback and change tolerance can vary also according to involved communities.

Agreed.

For this community, I suggest you build your skills for a while longer.

> > Why not concentrate on more complex submissions for a while and grow
> > your repertoire of common review points,
> 
> Further collateral evolution can be considered there depending on
> corresponding development resources.
> 
> > rather than repeating the same few over and over?
> 
> Some factors are probably known also according to corresponding statistics.
> Several contributors are stumbling on recurring improvement possibilities
> in published information.

Right, this will always be true, however the few you've picked up on
are not important enough to keep reiterating.  By doing so, you're
receiving undesirable attention.

> > Reading other, more experienced maintainer's reviews would also be a good use
> > of your time.
> 
> I am trying to influence adjustments in desirable directions for a while.

Never stop trying to improve.


These are only my opinions of course.  Take the advice or leave it.

There's no need to reply to this.

-- 
Lee Jones [李琼斯]