From: Nikolas Wipper <nikwip@amazon.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Nicolas Saenz Julienne <nsaenz@amazon.com>,
Alexander Graf <graf@amazon.de>,
James Gowans <jgowans@amazon.com>, <nh-open-source@amazon.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
<x86@kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <kvmarm@lists.linux.dev>,
<kvm-riscv@lists.infradead.org>,
Nikolas Wipper <nikwip@amazon.de>
Subject: [PATCH 14/15] KVM: x86: Implement KVM_TRANSLATE2
Date: Tue, 10 Sep 2024 15:22:06 +0000 [thread overview]
Message-ID: <20240910152207.38974-15-nikwip@amazon.de> (raw)
In-Reply-To: <20240910152207.38974-1-nikwip@amazon.de>
Implement KVM_TRANSLATE2 for x86 using the default KVM page walker.
Signed-off-by: Nikolas Wipper <nikwip@amazon.de>
---
arch/x86/kvm/x86.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 76 insertions(+)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 27fc71aaa1e4..3bcbad958324 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4683,6 +4683,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
case KVM_CAP_IRQFD_RESAMPLE:
case KVM_CAP_MEMORY_FAULT_INFO:
case KVM_CAP_X86_GUEST_MODE:
+ case KVM_CAP_TRANSLATE2:
r = 1;
break;
case KVM_CAP_PRE_FAULT_MEMORY:
@@ -12156,6 +12157,81 @@ int kvm_arch_vcpu_ioctl_translate(struct kvm_vcpu *vcpu,
return 0;
}
+/*
+ * Translate a guest virtual address to a guest physical address.
+ */
+int kvm_arch_vcpu_ioctl_translate2(struct kvm_vcpu *vcpu,
+ struct kvm_translation2 *tr)
+{
+ int idx, set_bit_mode = 0, access = 0;
+ struct x86_exception exception = { };
+ gva_t vaddr = tr->linear_address;
+ u16 status = 0;
+ gpa_t gpa;
+
+ if (tr->flags & KVM_TRANSLATE_FLAGS_SET_ACCESSED)
+ set_bit_mode |= PWALK_SET_ACCESSED;
+ if (tr->flags & KVM_TRANSLATE_FLAGS_SET_DIRTY)
+ set_bit_mode |= PWALK_SET_DIRTY;
+ if (tr->flags & KVM_TRANSLATE_FLAGS_FORCE_SET_ACCESSED)
+ set_bit_mode |= PWALK_FORCE_SET_ACCESSED;
+
+ if (tr->access & KVM_TRANSLATE_ACCESS_WRITE)
+ access |= PFERR_WRITE_MASK;
+ if (tr->access & KVM_TRANSLATE_ACCESS_USER)
+ access |= PFERR_USER_MASK;
+ if (tr->access & KVM_TRANSLATE_ACCESS_EXEC)
+ access |= PFERR_FETCH_MASK;
+
+ vcpu_load(vcpu);
+
+ idx = srcu_read_lock(&vcpu->kvm->srcu);
+
+ /* Even with PAE virtual addresses are still 32-bit */
+ if (is_64_bit_mode(vcpu) ? is_noncanonical_address(vaddr, vcpu) :
+ tr->linear_address >> 32) {
+ tr->valid = false;
+ tr->error_code = KVM_TRANSLATE_FAULT_INVALID_GVA;
+ goto exit;
+ }
+
+ gpa = kvm_mmu_gva_to_gpa(vcpu, vaddr, access, set_bit_mode, &exception,
+ &status);
+
+ tr->physical_address = exception.error_code_valid ? exception.gpa_page_fault : gpa;
+ tr->valid = !exception.error_code_valid;
+
+ /*
+ * Order is important here:
+ * - If there are access restrictions those will always be set in the
+ * error_code
+ * - If a PTE GPA is unmapped, the present bit in error_code may not
+ * have been set already
+ */
+ if (exception.flags & KVM_X86_UNMAPPED_PTE_GPA)
+ tr->error_code = KVM_TRANSLATE_FAULT_INVALID_GPA;
+ else if (!(exception.error_code & PFERR_PRESENT_MASK))
+ tr->error_code = KVM_TRANSLATE_FAULT_NOT_PRESENT;
+ else if (exception.error_code & PFERR_RSVD_MASK)
+ tr->error_code = KVM_TRANSLATE_FAULT_RESERVED_BITS;
+ else if (exception.error_code & (PFERR_USER_MASK | PFERR_WRITE_MASK |
+ PFERR_FETCH_MASK))
+ tr->error_code = KVM_TRANSLATE_FAULT_PRIVILEGE_VIOLATION;
+
+ /*
+ * exceptions.flags and thus tr->set_bits_succeeded have meaning
+ * regardless of the success of the page walk.
+ */
+ tr->set_bits_succeeded = tr->flags &&
+ !(status & PWALK_STATUS_READ_ONLY_PTE_GPA);
+
+exit:
+ srcu_read_unlock(&vcpu->kvm->srcu, idx);
+
+ vcpu_put(vcpu);
+ return 0;
+}
+
int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
{
struct fxregs_state *fxsave;
--
2.40.1
Amazon Web Services Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597
next prev parent reply other threads:[~2024-09-10 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 15:21 [PATCH 00/15] KVM: x86: Introduce new ioctl KVM_TRANSLATE2 Nikolas Wipper
2024-09-10 15:21 ` [PATCH 01/15] KVM: Add API documentation for KVM_TRANSLATE2 Nikolas Wipper
2024-09-10 15:21 ` [PATCH 02/15] KVM: x86/mmu: Abort page walk if permission checks fail Nikolas Wipper
2024-09-10 15:21 ` [PATCH 03/15] KVM: x86/mmu: Introduce exception flag for unmapped GPAs Nikolas Wipper
2024-09-10 15:21 ` [PATCH 04/15] KVM: x86/mmu: Store GPA in exception if applicable Nikolas Wipper
2024-09-10 15:21 ` [PATCH 05/15] KVM: x86/mmu: Introduce flags parameter to page walker Nikolas Wipper
2024-09-10 15:21 ` [PATCH 06/15] KVM: x86/mmu: Implement PWALK_SET_ACCESSED in " Nikolas Wipper
2024-09-10 15:21 ` [PATCH 07/15] KVM: x86/mmu: Implement PWALK_SET_DIRTY " Nikolas Wipper
2024-09-10 15:22 ` [PATCH 08/15] KVM: x86/mmu: Implement PWALK_FORCE_SET_ACCESSED " Nikolas Wipper
2024-09-10 15:22 ` [PATCH 09/15] KVM: x86/mmu: Introduce status parameter to " Nikolas Wipper
2024-09-10 15:22 ` [PATCH 10/15] KVM: x86/mmu: Implement PWALK_STATUS_READ_ONLY_PTE_GPA in " Nikolas Wipper
2024-09-10 15:22 ` [PATCH 11/15] KVM: x86: Introduce generic gva to gpa translation function Nikolas Wipper
2024-09-10 15:22 ` [PATCH 12/15] KVM: Introduce KVM_TRANSLATE2 Nikolas Wipper
2024-09-10 15:22 ` [PATCH 13/15] KVM: Add KVM_TRANSLATE2 stub Nikolas Wipper
2024-09-10 15:22 ` Nikolas Wipper [this message]
2024-12-11 22:06 ` [PATCH 14/15] KVM: x86: Implement KVM_TRANSLATE2 Sean Christopherson
2024-09-10 15:22 ` [PATCH 15/15] KVM: selftests: Add test for KVM_TRANSLATE2 Nikolas Wipper
2024-10-04 10:44 ` [PATCH 00/15] KVM: x86: Introduce new ioctl KVM_TRANSLATE2 Nikolas Wipper
2024-12-11 22:05 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910152207.38974-15-nikwip@amazon.de \
--to=nikwip@amazon.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=graf@amazon.de \
--cc=jgowans@amazon.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nh-open-source@amazon.com \
--cc=nsaenz@amazon.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).