From: Simon Horman <horms@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
thomas.petazzoni@bootlin.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue
Date: Thu, 12 Sep 2024 09:09:29 +0100 [thread overview]
Message-ID: <20240912080929.GD572255@kernel.org> (raw)
In-Reply-To: <20240911144711.693216-1-kory.maincent@bootlin.com>
On Wed, Sep 11, 2024 at 04:47:11PM +0200, Kory Maincent wrote:
> Fix a missing end of phrase in the documentation. It describes the
> ETHTOOL_A_C33_PSE_ACTUAL_PW attribute, which was not fully explained.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Documentation/networking/ethtool-netlink.rst | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index ba90457b8b2d..b1390878ba84 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -1801,8 +1801,9 @@ the PSE and the PD. This option is corresponding to ``IEEE 802.3-2022``
> 30.9.1.1.8 aPSEPowerClassification.
>
> When set, the optional ``ETHTOOL_A_C33_PSE_ACTUAL_PW`` attribute identifies
> -This option is corresponding to ``IEEE 802.3-2022`` 30.9.1.1.23 aPSEActualPower.
> -Actual power is reported in mW.
> +the actual power drawn by the C33 PSE. This option is corresponding to
nit: While we are here, perhaps we can also update the grammar.
This attribute corresponds to...
> +``IEEE 802.3-2022`` 30.9.1.1.23 aPSEActualPower. Actual power is reported
> +in mW.
>
> When set, the optional ``ETHTOOL_A_C33_PSE_EXT_STATE`` attribute identifies
> the extended error state of the C33 PSE. Possible values are:
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2024-09-12 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 14:47 [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue Kory Maincent
2024-09-11 18:21 ` Oleksij Rempel
2024-09-12 8:09 ` Simon Horman [this message]
2024-09-12 8:59 ` Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912080929.GD572255@kernel.org \
--to=horms@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).