* [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue
@ 2024-09-11 14:47 Kory Maincent
2024-09-11 18:21 ` Oleksij Rempel
2024-09-12 8:09 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Kory Maincent @ 2024-09-11 14:47 UTC (permalink / raw)
To: netdev, linux-doc, linux-kernel
Cc: Jakub Kicinski, Oleksij Rempel, Kory Maincent, thomas.petazzoni,
David S. Miller, Eric Dumazet, Paolo Abeni, Jonathan Corbet
Fix a missing end of phrase in the documentation. It describes the
ETHTOOL_A_C33_PSE_ACTUAL_PW attribute, which was not fully explained.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Documentation/networking/ethtool-netlink.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
index ba90457b8b2d..b1390878ba84 100644
--- a/Documentation/networking/ethtool-netlink.rst
+++ b/Documentation/networking/ethtool-netlink.rst
@@ -1801,8 +1801,9 @@ the PSE and the PD. This option is corresponding to ``IEEE 802.3-2022``
30.9.1.1.8 aPSEPowerClassification.
When set, the optional ``ETHTOOL_A_C33_PSE_ACTUAL_PW`` attribute identifies
-This option is corresponding to ``IEEE 802.3-2022`` 30.9.1.1.23 aPSEActualPower.
-Actual power is reported in mW.
+the actual power drawn by the C33 PSE. This option is corresponding to
+``IEEE 802.3-2022`` 30.9.1.1.23 aPSEActualPower. Actual power is reported
+in mW.
When set, the optional ``ETHTOOL_A_C33_PSE_EXT_STATE`` attribute identifies
the extended error state of the C33 PSE. Possible values are:
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue
2024-09-11 14:47 [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue Kory Maincent
@ 2024-09-11 18:21 ` Oleksij Rempel
2024-09-12 8:09 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2024-09-11 18:21 UTC (permalink / raw)
To: Kory Maincent
Cc: netdev, linux-doc, linux-kernel, Jakub Kicinski, thomas.petazzoni,
David S. Miller, Eric Dumazet, Paolo Abeni, Jonathan Corbet
On Wed, Sep 11, 2024 at 04:47:11PM +0200, Kory Maincent wrote:
> Fix a missing end of phrase in the documentation. It describes the
> ETHTOOL_A_C33_PSE_ACTUAL_PW attribute, which was not fully explained.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue
2024-09-11 14:47 [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue Kory Maincent
2024-09-11 18:21 ` Oleksij Rempel
@ 2024-09-12 8:09 ` Simon Horman
2024-09-12 8:59 ` Kory Maincent
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2024-09-12 8:09 UTC (permalink / raw)
To: Kory Maincent
Cc: netdev, linux-doc, linux-kernel, Jakub Kicinski, Oleksij Rempel,
thomas.petazzoni, David S. Miller, Eric Dumazet, Paolo Abeni,
Jonathan Corbet
On Wed, Sep 11, 2024 at 04:47:11PM +0200, Kory Maincent wrote:
> Fix a missing end of phrase in the documentation. It describes the
> ETHTOOL_A_C33_PSE_ACTUAL_PW attribute, which was not fully explained.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Documentation/networking/ethtool-netlink.rst | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index ba90457b8b2d..b1390878ba84 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -1801,8 +1801,9 @@ the PSE and the PD. This option is corresponding to ``IEEE 802.3-2022``
> 30.9.1.1.8 aPSEPowerClassification.
>
> When set, the optional ``ETHTOOL_A_C33_PSE_ACTUAL_PW`` attribute identifies
> -This option is corresponding to ``IEEE 802.3-2022`` 30.9.1.1.23 aPSEActualPower.
> -Actual power is reported in mW.
> +the actual power drawn by the C33 PSE. This option is corresponding to
nit: While we are here, perhaps we can also update the grammar.
This attribute corresponds to...
> +``IEEE 802.3-2022`` 30.9.1.1.23 aPSEActualPower. Actual power is reported
> +in mW.
>
> When set, the optional ``ETHTOOL_A_C33_PSE_EXT_STATE`` attribute identifies
> the extended error state of the C33 PSE. Possible values are:
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue
2024-09-12 8:09 ` Simon Horman
@ 2024-09-12 8:59 ` Kory Maincent
0 siblings, 0 replies; 4+ messages in thread
From: Kory Maincent @ 2024-09-12 8:59 UTC (permalink / raw)
To: Simon Horman
Cc: netdev, linux-doc, linux-kernel, Jakub Kicinski, Oleksij Rempel,
thomas.petazzoni, David S. Miller, Eric Dumazet, Paolo Abeni,
Jonathan Corbet
On Thu, 12 Sep 2024 09:09:29 +0100
Simon Horman <horms@kernel.org> wrote:
> On Wed, Sep 11, 2024 at 04:47:11PM +0200, Kory Maincent wrote:
> > Fix a missing end of phrase in the documentation. It describes the
> > ETHTOOL_A_C33_PSE_ACTUAL_PW attribute, which was not fully explained.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > Documentation/networking/ethtool-netlink.rst | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/networking/ethtool-netlink.rst
> > b/Documentation/networking/ethtool-netlink.rst index
> > ba90457b8b2d..b1390878ba84 100644 ---
> > a/Documentation/networking/ethtool-netlink.rst +++
> > b/Documentation/networking/ethtool-netlink.rst @@ -1801,8 +1801,9 @@ the
> > PSE and the PD. This option is corresponding to ``IEEE 802.3-2022``
> > 30.9.1.1.8 aPSEPowerClassification.
> > When set, the optional ``ETHTOOL_A_C33_PSE_ACTUAL_PW`` attribute identifies
> > -This option is corresponding to ``IEEE 802.3-2022`` 30.9.1.1.23
> > aPSEActualPower. -Actual power is reported in mW.
> > +the actual power drawn by the C33 PSE. This option is corresponding to
>
> nit: While we are here, perhaps we can also update the grammar.
>
> This attribute corresponds to...
Yes, indeed. Thanks.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-12 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-11 14:47 [PATCH net-next] Documentation: networking: Fix missing PSE documentation issue Kory Maincent
2024-09-11 18:21 ` Oleksij Rempel
2024-09-12 8:09 ` Simon Horman
2024-09-12 8:59 ` Kory Maincent
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).