Re: [PATCH v2 07/10] iio: adc: ad7606: Add compatibility to fw_nodes

David Lechner
2024-09-24T15:28:51Z

On Fri, Sep 20, 2024 at 7:33 PM Guillaume Stols <gstols@baylibre.com> wrote:
>
> On the parallel version, the current implementation is only compatible
> with id tables and won't work with fw_nodes, this commit intends to fix
> it.
>
> Also, chip info is moved in the .h file so to be accessible to all the
> driver files that can set a pointer to the corresponding chip as the
> driver data.

This sounds like two unrelated changes, so maybe we should have two patches?

> static const struct of_device_id ad7606_of_match[] = {
> - { .compatible = "adi,ad7605-4" },
> - { .compatible = "adi,ad7606-4" },
> - { .compatible = "adi,ad7606-6" },
> - { .compatible = "adi,ad7606-8" },
> - { .compatible = "adi,ad7606b" },
> - { .compatible = "adi,ad7616" },
> + { .compatible = "adi,ad7605-4", &ad7605_4_info },
> + { .compatible = "adi,ad7606-4", &ad7606_4_info },
> + { .compatible = "adi,ad7606-6", &ad7606_6_info },
> + { .compatible = "adi,ad7606-8", &ad7606_8_info },
> + { .compatible = "adi,ad7606b", &ad7606b_info },
> + { .compatible = "adi,ad7616", &ad7616_info },

Since we have .compatible = , we should also have .data = for the chip info.