From: Daniel Thompson <daniel.thompson@linaro.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Jason Wessel <jason.wessel@windriver.com>,
Douglas Anderson <dianders@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
kgdb-bugreport@lists.sourceforge.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Documentation: kgdb: Correct parameter error
Date: Mon, 30 Sep 2024 10:29:07 +0100 [thread overview]
Message-ID: <20240930092907.GD5584@aspen.lan> (raw)
In-Reply-To: <20240925100742.1730576-1-changhuang.liang@starfivetech.com>
On Wed, Sep 25, 2024 at 03:07:42AM -0700, Changhuang Liang wrote:
> Module kgdb had been converted to debug_core since commit c433820971ff
> ("Move kernel/kgdb.c to kernel/debug/debug_core.c") be added, so let's
> correct the module parameter path.
>
> Fixes: c433820971ff ("Move kernel/kgdb.c to kernel/debug/debug_core.c")
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
@Jon: Do you want me to hoover this up or will you take it? If you are
happy to grab it then feel free to treat my Rb: as an Acked-by: too!
Daniel.
> ---
>
> Hi,
>
> v3: I wrote a error change log in v2. Now fix it.
>
> Documentation/dev-tools/kgdb.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index f83ba2601e55..a87a58e6509a 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -329,7 +329,7 @@ ways to activate this feature.
>
> 2. Use sysfs before configuring an I/O driver::
>
> - echo 1 > /sys/module/kgdb/parameters/kgdb_use_con
> + echo 1 > /sys/module/debug_core/parameters/kgdb_use_con
>
> .. note::
>
> --
> 2.25.1
next prev parent reply other threads:[~2024-09-30 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 10:07 [PATCH v3] Documentation: kgdb: Correct parameter error Changhuang Liang
2024-09-30 9:29 ` Daniel Thompson [this message]
2024-09-30 17:21 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930092907.GD5584@aspen.lan \
--to=daniel.thompson@linaro.org \
--cc=changhuang.liang@starfivetech.com \
--cc=corbet@lwn.net \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).