* [PATCH v3] Documentation: kgdb: Correct parameter error
@ 2024-09-25 10:07 Changhuang Liang
2024-09-30 9:29 ` Daniel Thompson
0 siblings, 1 reply; 3+ messages in thread
From: Changhuang Liang @ 2024-09-25 10:07 UTC (permalink / raw)
To: Jason Wessel, Daniel Thompson, Douglas Anderson
Cc: Jonathan Corbet, Mauro Carvalho Chehab, Changhuang Liang,
kgdb-bugreport, linux-doc, linux-kernel
Module kgdb had been converted to debug_core since commit c433820971ff
("Move kernel/kgdb.c to kernel/debug/debug_core.c") be added, so let's
correct the module parameter path.
Fixes: c433820971ff ("Move kernel/kgdb.c to kernel/debug/debug_core.c")
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Hi,
v3: I wrote a error change log in v2. Now fix it.
Documentation/dev-tools/kgdb.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
index f83ba2601e55..a87a58e6509a 100644
--- a/Documentation/dev-tools/kgdb.rst
+++ b/Documentation/dev-tools/kgdb.rst
@@ -329,7 +329,7 @@ ways to activate this feature.
2. Use sysfs before configuring an I/O driver::
- echo 1 > /sys/module/kgdb/parameters/kgdb_use_con
+ echo 1 > /sys/module/debug_core/parameters/kgdb_use_con
.. note::
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] Documentation: kgdb: Correct parameter error
2024-09-25 10:07 [PATCH v3] Documentation: kgdb: Correct parameter error Changhuang Liang
@ 2024-09-30 9:29 ` Daniel Thompson
2024-09-30 17:21 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Thompson @ 2024-09-30 9:29 UTC (permalink / raw)
To: Changhuang Liang
Cc: Jason Wessel, Douglas Anderson, Jonathan Corbet,
Mauro Carvalho Chehab, kgdb-bugreport, linux-doc, linux-kernel
On Wed, Sep 25, 2024 at 03:07:42AM -0700, Changhuang Liang wrote:
> Module kgdb had been converted to debug_core since commit c433820971ff
> ("Move kernel/kgdb.c to kernel/debug/debug_core.c") be added, so let's
> correct the module parameter path.
>
> Fixes: c433820971ff ("Move kernel/kgdb.c to kernel/debug/debug_core.c")
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
@Jon: Do you want me to hoover this up or will you take it? If you are
happy to grab it then feel free to treat my Rb: as an Acked-by: too!
Daniel.
> ---
>
> Hi,
>
> v3: I wrote a error change log in v2. Now fix it.
>
> Documentation/dev-tools/kgdb.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index f83ba2601e55..a87a58e6509a 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -329,7 +329,7 @@ ways to activate this feature.
>
> 2. Use sysfs before configuring an I/O driver::
>
> - echo 1 > /sys/module/kgdb/parameters/kgdb_use_con
> + echo 1 > /sys/module/debug_core/parameters/kgdb_use_con
>
> .. note::
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] Documentation: kgdb: Correct parameter error
2024-09-30 9:29 ` Daniel Thompson
@ 2024-09-30 17:21 ` Jonathan Corbet
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2024-09-30 17:21 UTC (permalink / raw)
To: Daniel Thompson, Changhuang Liang
Cc: Jason Wessel, Douglas Anderson, Mauro Carvalho Chehab,
kgdb-bugreport, linux-doc, linux-kernel
Daniel Thompson <daniel.thompson@linaro.org> writes:
> On Wed, Sep 25, 2024 at 03:07:42AM -0700, Changhuang Liang wrote:
>> Module kgdb had been converted to debug_core since commit c433820971ff
>> ("Move kernel/kgdb.c to kernel/debug/debug_core.c") be added, so let's
>> correct the module parameter path.
>>
>> Fixes: c433820971ff ("Move kernel/kgdb.c to kernel/debug/debug_core.c")
>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> @Jon: Do you want me to hoover this up or will you take it? If you are
> happy to grab it then feel free to treat my Rb: as an Acked-by: too!
Sure, I can grab it in a bit.
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-30 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25 10:07 [PATCH v3] Documentation: kgdb: Correct parameter error Changhuang Liang
2024-09-30 9:29 ` Daniel Thompson
2024-09-30 17:21 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).