From: Tony Luck <tony.luck@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Peter Newman <peternewman@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
x86@kernel.org
Cc: Shaopeng Tan <tan.shaopeng@fujitsu.com>,
James Morse <james.morse@arm.com>,
Jamie Iles <quic_jiles@quicinc.com>,
Babu Moger <babu.moger@amd.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
patches@lists.linux.dev, Tony Luck <tony.luck@intel.com>
Subject: [PATCH v7 0/4] x86/resctrl: mba_MBps enhancements
Date: Thu, 3 Oct 2024 12:12:24 -0700 [thread overview]
Message-ID: <20241003191228.67541-1-tony.luck@intel.com> (raw)
[
Bringing this old patch series out of hibernation since last December
]
Two changes relating to the MBA Software Controller(mba_sc):
1) Add a new mount option so the user can choose which memory
bandwidth monitoring event to use as the input to the feedback
loop.
2) Update the "mba_MBps" mount option to make use of total memory
bandwidth event on systems that do not support local bandwidth
event.
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
Changes since v6: https://lore.kernel.org/all/20231207195613.153980-1-tony.luck@intel.com/
Peter Newman:
s/"mbm_Local_bytes"/"mbm_local_bytes"/
Added WARN_ON() to check non-null return from get_mbm_state()
Don't allow both local and total mount options at same time
Reinette Chatre:
Use flag (enable_mba_mbps) and value (mba_mbps_event) in
struct rdt_fs_context. Then pass the value to r->membw.mba_mbps_event
Ditto Peter's comment to block multiple uses of mount options.
Use invalfc() for better error reporting to user
Note in kerneldoc that mba_mbps_event only valid when @mba_sc is true
Declare mba_sc_event_opt_name() as "const char *"
Rework resctrl.rst patch based on comments
Babu Moger:
Clean up calling sequence for set_mba_sc() to avoid dummy 2nd argument
Other changes:
I split first patch into two parts:
1) the periodic updates to use r->membw.mba_mbps_event to choose
the event
2) The new mount option
Also noticed code duplication in mbm_update() as the local
and total clauses are now identical. Split that code into
a helper function mbm_update_one_event()
Tony Luck (4):
x86/resctrl: Make input event for MBA Software Controller configurable
x86/resctrl: Add mount option to pick input event for mba_MBps mode
x86/resctrl: Use total bandwidth for mba_MBps option when local isn't
present
x86/resctrl: Add new "mba_MBps_event" mount option to documentation
Documentation/arch/x86/resctrl.rst | 27 +++++++--
include/linux/resctrl.h | 2 +
arch/x86/kernel/cpu/resctrl/internal.h | 1 +
arch/x86/kernel/cpu/resctrl/monitor.c | 80 ++++++++++++--------------
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 51 +++++++++++++---
5 files changed, 102 insertions(+), 59 deletions(-)
--
2.46.1
next reply other threads:[~2024-10-03 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 19:12 Tony Luck [this message]
2024-10-03 19:12 ` [PATCH v7 1/4] x86/resctrl: Make input event for MBA Software Controller configurable Tony Luck
2024-10-25 17:36 ` Reinette Chatre
2024-10-25 20:42 ` Luck, Tony
2024-10-25 22:00 ` Reinette Chatre
2024-10-03 19:12 ` [PATCH v7 2/4] x86/resctrl: Add mount option to pick input event for mba_MBps mode Tony Luck
2024-10-03 19:12 ` [PATCH v7 3/4] x86/resctrl: Use total bandwidth for mba_MBps option when local isn't present Tony Luck
2024-10-03 19:12 ` [PATCH v7 4/4] x86/resctrl: Add new "mba_MBps_event" mount option to documentation Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003191228.67541-1-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=babu.moger@amd.com \
--cc=corbet@lwn.net \
--cc=fenghua.yu@intel.com \
--cc=james.morse@arm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=skhan@linuxfoundation.org \
--cc=tan.shaopeng@fujitsu.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox