From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
donald.hunter@redhat.com
Subject: Re: [PATCH net-next v1] doc: net: Fix .rst rendering of net_cachelines pages
Date: Fri, 4 Oct 2024 16:18:32 -0700 [thread overview]
Message-ID: <20241004161832.056fa9d0@kernel.org> (raw)
In-Reply-To: <20241003205248.61445-1-donald.hunter@gmail.com>
On Thu, 3 Oct 2024 21:52:48 +0100 Donald Hunter wrote:
> The doc pages under /networking/net_cachelines are unreadable because
> they lack .rst formatting for the tabular text.
>
> Add simple table markup and tidy up the table contents:
>
> - remove dashes that represent empty cells because they render
> as bullets and are not needed
> - replace 'struct_*' with 'struct *' in the first column so that
> sphinx can render links for any structs that appear in the docs
Thanks for doing this! Looks like the files have diverged before we got
to applying it, could you rebase?
Applying: doc: net: Fix .rst rendering of net_cachelines pages
error: patch failed: Documentation/networking/net_cachelines/net_device.rst:5
error: Documentation/networking/net_cachelines/net_device.rst: patch does not apply
Patch failed at 0001 doc: net: Fix .rst rendering of net_cachelines pages
--
pw-bot: cr
prev parent reply other threads:[~2024-10-04 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 20:52 [PATCH net-next v1] doc: net: Fix .rst rendering of net_cachelines pages Donald Hunter
2024-10-04 2:49 ` Bagas Sanjaya
2024-10-04 23:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004161832.056fa9d0@kernel.org \
--to=kuba@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).