Re: [PATCH RFC 1/4] dt-bindings: iio: adc: ad7380: add adaq4370-4 and adaq4380-4 compatible parts

Rob Herring
2024-10-15T20:49:18Z

On Tue, Oct 15, 2024 at 11:09:06AM +0200, Julien Stephan wrote:
> adaq4370-4 (2MSPS) and adaq4380-4 (4MSPS) are quad-channel precision data
> acquisition signal chain μModule solutions compatible with the ad738x
> family, with the following differences:
>
> - configurable gain in front of each 4 adc
> - internal reference is 3V derived from refin-supply (5V)
> - additional supplies
>
> To configure the gain a new patternProperties is added to describe each
> channel. It is restricted to adaq devices.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---
> .../devicetree/bindings/iio/adc/adi,ad7380.yaml | 117 +++++++++++++++++++++
> 1 file changed, 117 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml
> index 74d82721637c..3007d8e39684 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml
> @@ -25,6 +25,8 @@ description: |
> * https://www.analog.com/en/products/ad7386-4.html
> * https://www.analog.com/en/products/ad7387-4.html
> * https://www.analog.com/en/products/ad7388-4.html
> + * https://www.analog.com/en/products/adaq4370-4.html
> + * https://www.analog.com/en/products/adaq4380-4.html
>
>
> $ref: /schemas/spi/spi-peripheral-props.yaml#
> @@ -46,6 +48,8 @@ properties:
> - adi,ad7386-4
> - adi,ad7387-4
> - adi,ad7388-4
> + - adi,adaq4370-4
> + - adi,adaq4380-4
>
> reg:
> maxItems: 1
> @@ -59,6 +63,9 @@ properties:
> vlogic-supply: true
> refio-supply: true
> refin-supply: true
> + vs-p-supply: true
> + vs-n-supply: true
> + ldo-supply: true
>
> aina-supply:
> description:
> @@ -86,12 +93,43 @@ properties:
> specify the ALERT interrupt.
> maxItems: 1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> required:
> - compatible
> - reg
> - vcc-supply
> - vlogic-supply
>
> +patternProperties:
> + "^channel@([0-3])$":
> + $ref: adc.yaml
> + type: object
> +
> + properties:
> + reg:
> + description:
> + The channel number. From 0 to 3 corresponding to channels A,B,C,D
> + items:
> + minimum: 0
> + maximum: 3

This allows mutiple entries. Is that intended? If so, define the range
(minItems/maxItems). If not, drop 'items'.

> +
> + adi,gain-milli:
> + description:
> + The hardware gain applied to the ADC input (in milli units).
> + If not present, default to 1000 (no actual gain applied).
> + $ref: /schemas/types.yaml#/definitions/uint32

Elsewhere the same property is a uint16. Don't define different types
for the same property name.

> + default: 1000

Constraints? minimum/maximum/enum?