Re: [PATCH v4 3/4] proc_pid_fdinfo.5: Add subsection headers for different fd types

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]

Hi Branden, Ian,

On Sat, Nov 02, 2024 at 04:20:07AM -0500, G. Branden Robinson wrote:
> Hi Ian,
> 
> At 2024-11-01T14:18:29-0700, Ian Rogers wrote:
> > Make the sections about eventfd, epoll, signalfd, inotify, fanotify,
> > timerfd better separated with a clearer subsection header.
> > 
> > Signed-off-by: Ian Rogers <irogers@google.com>
> [...]
> > +.SS eventfd
> >  .P
> [...]
> > +.SS epoll
> >  .P
> [...]
> > +.SS signalfd
> >  .P
> [...]
> > +.SS inotify
> >  .P
> [etc.]
> 
> I suggest deleting the paragraphing macros when you add (sub)sectioning
> macros immediately before them.  In these cases the `P` calls end up
> doing nothing.

Indeed.  We have warnings (see `make help`) that trigger for this.


Have a lovely day!
Alex

> 
> groff_man(7):
>        .SS [subheading‐text]
>               Set subheading‐text as a subsection heading indented
>               between a section heading and an ordinary paragraph (.P).
>               If no argument is given, a one‐line input trap is planted;
>               text on the next line becomes subheading‐text.  The left
>               margin is reset to the value of the SN register to set the
>               heading text in bold (or the font specified by the string
>               HF).  If the heading font \*[HF] is bold, use of an italic
>               style in subheading‐text is mapped to the bold‐italic
>               style if available in the font family.  The inset level is
>               reset to 1, setting the left margin to the value of the IN
>               register.  Text after subheading‐text is set as an
>               ordinary paragraph (.P).


-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]