From: Kory Maincent <kory.maincent@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Donald Hunter <donald.hunter@gmail.com>,
Rob Herring <robh@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, Kyle Swenson <kyle.swenson@est.tech>,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH RFC net-next v2 08/18] net: pse-pd: Add support for reporting events
Date: Tue, 5 Nov 2024 10:48:24 +0100 [thread overview]
Message-ID: <20241105104824.2bc51cf7@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <ede82d07-6adc-486a-b715-e6e783655333@lunn.ch>
On Thu, 31 Oct 2024 22:54:00 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> > +static struct phy_device *
> > +pse_control_find_phy_by_id(struct pse_controller_dev *pcdev, int id)
> > +{
> > + struct pse_control *psec;
> > +
> > + mutex_lock(&pse_list_mutex);
> > + list_for_each_entry(psec, &pcdev->pse_control_head, list) {
> > + if (psec->id == id)
> > + return psec->attached_phydev;
>
> The mutex is still locked. I'm surprised your testing did not
> deadlock, and that none of the automated tools have reported this.
Ouch indeed! As explained in the cover letter, this v2 has not been fully
tested.
But I have built it with smatch and sparse. Weirdly they didn't find it.
Thanks for seeing it.
> ---
> pw-bot: cr
Does RFC patch series pass through the netdev CI build test?
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-11-05 9:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 16:53 [PATCH RFC net-next v2 00/18] Add support for PSE port priority Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 01/18] net: pse-pd: Remove unused pse_ethtool_get_pw_limit function declaration Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 02/18] net: pse-pd: tps23881: Simplify function returns by removing redundant checks Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 03/18] net: pse-pd: tps23881: Use helpers to calculate bit offset for a channel Kory Maincent
2024-10-31 6:18 ` Oleksij Rempel
2024-10-31 21:11 ` Andrew Lunn
2024-11-07 10:47 ` Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 04/18] net: pse-pd: tps23881: Add support for power limit and measurement features Kory Maincent
2024-10-31 6:20 ` Oleksij Rempel
2024-10-30 16:53 ` [PATCH RFC net-next v2 05/18] net: pse-pd: Add support for PSE device index Kory Maincent
2024-10-31 6:27 ` Oleksij Rempel
2024-10-31 21:28 ` Andrew Lunn
2024-11-05 9:33 ` Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 06/18] net: ethtool: Add support for new PSE device index description Kory Maincent
2024-10-31 6:28 ` Oleksij Rempel
2024-10-31 21:29 ` Andrew Lunn
2024-10-31 21:39 ` Andrew Lunn
2024-10-30 16:53 ` [PATCH RFC net-next v2 07/18] net: ethtool: Add support for ethnl_info_init_ntf helper function Kory Maincent
2024-10-31 21:44 ` Andrew Lunn
2024-11-05 9:37 ` Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 08/18] net: pse-pd: Add support for reporting events Kory Maincent
2024-10-31 6:34 ` Oleksij Rempel
2024-10-31 21:54 ` Andrew Lunn
2024-11-05 9:48 ` Kory Maincent [this message]
2024-10-31 22:00 ` Andrew Lunn
2024-11-05 9:41 ` Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 09/18] netlink: specs: Add support for PSE netlink notifications Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 10/18] net: pse-pd: tps23881: Add support for PSE events and interrupts Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 11/18] regulator: Add support for power budget description Kory Maincent
2024-10-30 17:03 ` Mark Brown
2024-10-30 17:22 ` Kory Maincent
2024-10-30 17:31 ` Mark Brown
2024-10-30 16:53 ` [PATCH RFC net-next v2 12/18] regulator: dt-bindings: Add regulator-power-budget property Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 13/18] net: pse-pd: Add support for PSE power domains Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 14/18] net: ethtool: Add support for new power domains index description Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 15/18] net: pse-pd: Add support for getting and setting port priority Kory Maincent
2024-10-31 6:54 ` Oleksij Rempel
2024-10-31 11:11 ` Kory Maincent
2024-10-31 17:32 ` Oleksij Rempel
2024-11-05 13:49 ` Kory Maincent
2024-11-05 14:36 ` Oleksij Rempel
2024-11-01 8:31 ` Oleksij Rempel
2024-11-01 10:23 ` Oleksij Rempel
2024-11-05 10:20 ` Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 16/18] net: ethtool: Add PSE new port priority support feature Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 17/18] netlink: specs: Expand the PSE netlink command with newly supported features Kory Maincent
2024-10-30 16:53 ` [PATCH RFC net-next v2 18/18] net: pse-pd: pd692x0: Add support for PSE PI priority feature Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105104824.2bc51cf7@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox