* [PATCH] Corrected the spelling of dictionary in the example usage of 'algorithm_params' in the ZRAM documentation.
@ 2024-11-24 13:45 Saru2003
2024-11-25 2:49 ` Sergey Senozhatsky
0 siblings, 1 reply; 5+ messages in thread
From: Saru2003 @ 2024-11-24 13:45 UTC (permalink / raw)
To: minchan, senozhatsky
Cc: philipp.reisner, lars.ellenberg, christoph.boehmwalder, corbet,
terrelln, linux-kernel, drbd-dev, linux-doc, Saru2003
Signed-off-by: Saru2003 <sarvesh20123@gmail.com>
---
Documentation/admin-guide/blockdev/zram.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin-guide/blockdev/zram.rst b/Documentation/admin-guide/blockdev/zram.rst
index 678d70d6e1c3..dbf2b4f47ec3 100644
--- a/Documentation/admin-guide/blockdev/zram.rst
+++ b/Documentation/admin-guide/blockdev/zram.rst
@@ -119,14 +119,14 @@ compression algorithm to use external pre-trained dictionary, pass full
path to the `dict` along with other parameters::
#pass path to pre-trained zstd dictionary
- echo "algo=zstd dict=/etc/dictioary" > /sys/block/zram0/algorithm_params
+ echo "algo=zstd dict=/etc/dictionary" > /sys/block/zram0/algorithm_params
#same, but using algorithm priority
- echo "priority=1 dict=/etc/dictioary" > \
+ echo "priority=1 dict=/etc/dictionary" > \
/sys/block/zram0/algorithm_params
#pass path to pre-trained zstd dictionary and compression level
- echo "algo=zstd level=8 dict=/etc/dictioary" > \
+ echo "algo=zstd level=8 dict=/etc/dictionary" > \
/sys/block/zram0/algorithm_params
Parameters are algorithm specific: not all algorithms support pre-trained
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Corrected the spelling of dictionary in the example usage of 'algorithm_params' in the ZRAM documentation.
2024-11-24 13:45 [PATCH] Corrected the spelling of dictionary in the example usage of 'algorithm_params' in the ZRAM documentation Saru2003
@ 2024-11-25 2:49 ` Sergey Senozhatsky
2024-11-25 16:51 ` [PATCH v2] Documentation: zram: fix dictionary spelling Saru2003
0 siblings, 1 reply; 5+ messages in thread
From: Sergey Senozhatsky @ 2024-11-25 2:49 UTC (permalink / raw)
To: Saru2003
Cc: minchan, senozhatsky, philipp.reisner, lars.ellenberg,
christoph.boehmwalder, corbet, terrelln, linux-kernel, drbd-dev,
linux-doc
On (24/11/24 19:15), Saru2003 wrote:
> Signed-off-by: Saru2003 <sarvesh20123@gmail.com>
Can you please resend v2 with:
- updated subject "Documentation: zram: fix dictionary spelling"
- perhaps a short commit message is still needed
- I'd also assume your real name should be in SoB
Otherwise looks good.
FWIW,
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] Documentation: zram: fix dictionary spelling
2024-11-25 2:49 ` Sergey Senozhatsky
@ 2024-11-25 16:51 ` Saru2003
2024-11-26 4:32 ` Sergey Senozhatsky
2024-12-13 16:07 ` Jonathan Corbet
0 siblings, 2 replies; 5+ messages in thread
From: Saru2003 @ 2024-11-25 16:51 UTC (permalink / raw)
To: minchan, senozhatsky
Cc: philipp.reisner, lars.ellenberg, christoph.boehmwalder, corbet,
terrelln, linux-kernel, drbd-dev, linux-doc, Saru2003
Fixes a typo in the ZRAM documentation where 'dictioary' was
misspelled. Corrected it to 'dictionary' in the example usage
of 'algorithm_params'.
Signed-off-by: Sarveshwaar SS <sarvesh20123@gmail.com>
---
Documentation/admin-guide/blockdev/zram.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin-guide/blockdev/zram.rst b/Documentation/admin-guide/blockdev/zram.rst
index 678d70d6e1c3..dbf2b4f47ec3 100644
--- a/Documentation/admin-guide/blockdev/zram.rst
+++ b/Documentation/admin-guide/blockdev/zram.rst
@@ -119,14 +119,14 @@ compression algorithm to use external pre-trained dictionary, pass full
path to the `dict` along with other parameters::
#pass path to pre-trained zstd dictionary
- echo "algo=zstd dict=/etc/dictioary" > /sys/block/zram0/algorithm_params
+ echo "algo=zstd dict=/etc/dictionary" > /sys/block/zram0/algorithm_params
#same, but using algorithm priority
- echo "priority=1 dict=/etc/dictioary" > \
+ echo "priority=1 dict=/etc/dictionary" > \
/sys/block/zram0/algorithm_params
#pass path to pre-trained zstd dictionary and compression level
- echo "algo=zstd level=8 dict=/etc/dictioary" > \
+ echo "algo=zstd level=8 dict=/etc/dictionary" > \
/sys/block/zram0/algorithm_params
Parameters are algorithm specific: not all algorithms support pre-trained
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Documentation: zram: fix dictionary spelling
2024-11-25 16:51 ` [PATCH v2] Documentation: zram: fix dictionary spelling Saru2003
@ 2024-11-26 4:32 ` Sergey Senozhatsky
2024-12-13 16:07 ` Jonathan Corbet
1 sibling, 0 replies; 5+ messages in thread
From: Sergey Senozhatsky @ 2024-11-26 4:32 UTC (permalink / raw)
To: Saru2003
Cc: minchan, senozhatsky, philipp.reisner, lars.ellenberg,
christoph.boehmwalder, corbet, terrelln, linux-kernel, drbd-dev,
linux-doc
On (24/11/25 22:21), Saru2003 wrote:
>
> Fixes a typo in the ZRAM documentation where 'dictioary' was
> misspelled. Corrected it to 'dictionary' in the example usage
> of 'algorithm_params'.
>
> Signed-off-by: Sarveshwaar SS <sarvesh20123@gmail.com>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Documentation: zram: fix dictionary spelling
2024-11-25 16:51 ` [PATCH v2] Documentation: zram: fix dictionary spelling Saru2003
2024-11-26 4:32 ` Sergey Senozhatsky
@ 2024-12-13 16:07 ` Jonathan Corbet
1 sibling, 0 replies; 5+ messages in thread
From: Jonathan Corbet @ 2024-12-13 16:07 UTC (permalink / raw)
To: Saru2003, minchan, senozhatsky
Cc: philipp.reisner, lars.ellenberg, christoph.boehmwalder, terrelln,
linux-kernel, drbd-dev, linux-doc, Saru2003
Saru2003 <sarvesh20123@gmail.com> writes:
> Fixes a typo in the ZRAM documentation where 'dictioary' was
> misspelled. Corrected it to 'dictionary' in the example usage
> of 'algorithm_params'.
>
> Signed-off-by: Sarveshwaar SS <sarvesh20123@gmail.com>
> ---
> Documentation/admin-guide/blockdev/zram.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-13 16:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-24 13:45 [PATCH] Corrected the spelling of dictionary in the example usage of 'algorithm_params' in the ZRAM documentation Saru2003
2024-11-25 2:49 ` Sergey Senozhatsky
2024-11-25 16:51 ` [PATCH v2] Documentation: zram: fix dictionary spelling Saru2003
2024-11-26 4:32 ` Sergey Senozhatsky
2024-12-13 16:07 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).