Re: [PATCH] fs_parser: update mount_api doc to match function signature

[Jan Kara <jack@suse.cz>]

On Mon 25-11-24 13:50:21, Randy Dunlap wrote:
> Add the missing 'name' parameter to the mount_api documentation for
> fs_validate_description().
> 
> Fixes: 96cafb9ccb15 ("fs_parser: remove fs_parameter_description name field")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Eric Sandeen <sandeen@redhat.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  Documentation/filesystems/mount_api.rst |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-next-20241122.orig/Documentation/filesystems/mount_api.rst
> +++ linux-next-20241122/Documentation/filesystems/mount_api.rst
> @@ -770,7 +770,8 @@ process the parameters it is given.
>  
>     * ::
>  
> -       bool fs_validate_description(const struct fs_parameter_description *desc);
> +       bool fs_validate_description(const char *name,
> +                                    const struct fs_parameter_description *desc);
>  
>       This performs some validation checks on a parameter description.  It
>       returns true if the description is good and false if it is not.  It will
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR