Re: [PATCH v3 5/7] dt-bindings: iio: Add adis16550 bindings

Jonathan Cameron
2024-12-19T17:25:35Z

On Mon, 16 Dec 2024 16:48:11 +0200
Robert Budai <robert.budai@analog.com> wrote:

> Document the ADIS16550 device devicetree bindings.
>
> Co-developed-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> Signed-off-by: Robert Budai <robert.budai@analog.com>
> ---
>
> v3:
> - changed sync type to integer
> - conditioned clock only on scaled-sync
> - added: unevaluatedProperties false
>
> .../bindings/iio/imu/adi,adis16550.yaml | 93 +++++++++++++++++++
> MAINTAINERS | 9 ++
> 2 files changed, 102 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml
> new file mode 100644
> index 000000000000..e0b07b912484
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16550.yaml
> @@ -0,0 +1,93 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/imu/adi,adis16550.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADIS16550 and similar IMUs
> +
> +maintainers:
> + - Nuno Sa <nuno.sa@analog.com>
> + - Ramona Gradinariu <ramona.gradinariu@analog.com>
> + - Antoniu Miclaus <antoniu.miclaus@analog.com>
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adis16550
> + - adi,adis16550w
> +
> + reg:
> + maxItems: 1
> +
> + spi-cpha: true
> +
> + spi-cpol: true
> +
> + spi-max-frequency:
> + maximum: 15000000
> +
> + vdd-supply: true
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + description:
> + RESET active low pin.
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description: If not provided, then the internal clock is used.
> +
> + adi,sync-mode:
This is at least one of the things the bot is complaining about. Too deep on the indent.
> + description:
> + Configures the device SYNC pin. The following modes are supported
> + 0 - direct_sync
> + 1 - scaled_sync

Ah. I see this is lined up with some existing binding.
you should keep the values the same as well given direct and scaled are already in the adis16475 binding.
Just use an enum to constrain the values 1 and 2

> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - spi-cpha
> + - spi-cpol
> + - spi-max-frequency
> + - vdd-supply