Re: [PATCH v2 6/6] docs: iio: ad4030: add documentation

Jonathan Cameron
2024-12-23T12:23:13Z

On Thu, 19 Dec 2024 17:10:41 +0100
Esteban Blanc <eblanc@baylibre.com> wrote:

> This adds a new page to document how to use the ad4030 ADC driver
>
> Signed-off-by: Esteban Blanc <eblanc@baylibre.com>
> ---
> Documentation/iio/ad4030.rst | 181 +++++++++++++++++++++++++++++++++++++++++++
> Documentation/iio/index.rst | 1 +
> MAINTAINERS | 1 +
> 3 files changed, 183 insertions(+)
>
> diff --git a/Documentation/iio/ad4030.rst b/Documentation/iio/ad4030.rst
> new file mode 100644
> index 0000000000000000000000000000000000000000..41ce5ca5c710c46a0995d1b127fa1c10fca4c1eb
> --- /dev/null
> +++ b/Documentation/iio/ad4030.rst
> @@ -0,0 +1,181 @@
> +.. SPDX-License-Identifier: GPL-2.0-only
> +
> +=============
> +AD4030 driver
> +=============
> +
> +ADC driver for Analog Devices Inc. AD4030 and similar devices. The module name
> +is ``ad4030``.
> +
> +
> +Supported devices
> +=================
> +
> +The following chips are supported by this driver:
> +
> +* `AD4030-24 <https://www.analog.com/AD4030-24>`_
> +* `AD4032-24 <https://www.analog.com/AD4032-24>`_

I don't see this one in the driver. It's in the bindings but
not the ID tables. Got lost somewhere or should have a fallback compatible?
A very quick glances suggests it might just be a down rated version
of AD4030-24

> +* `AD4630-16 <https://www.analog.com/AD4630-16>`_
> +* `AD4630-24 <https://www.analog.com/AD4630-24>`_
> +* `AD4632-16 <https://www.analog.com/AD4632-16>`_
> +* `AD4632-24 <https://www.analog.com/AD4632-24>`_

Other than that this looks good as do patches 3-5.

Thanks,

Jonathan