From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: "Julien Stephan" <jstephan@baylibre.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH RFC v2 2/4] iio: adc: ad7380: enable regmap cache
Date: Sat, 28 Dec 2024 14:07:04 +0000 [thread overview]
Message-ID: <20241228140704.7115fb23@jic23-huawei> (raw)
In-Reply-To: <zkur45la23hyqmqusjdfyzgsofhfli3n54be55dkdrwtxf5g7e@fdpdeliljyz3>
On Fri, 27 Dec 2024 09:48:35 +0100
Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
> On Tue, Dec 24, 2024 at 10:34:31AM +0100, Julien Stephan wrote:
> > Enable regmap cache, to avoid useless access on spi bus.
> > Don't store anymore the oversampling ratio in private data structure.
>
> I would split that.
Splitting it probably makes sense, though the regcache enabling patch will be small
(which is fine).
> There are a few changes in this patch that I don't
> understand, e.g. why does the return type of ad7380_update_xfers()
> change?
On first call of this, the register contents may not be in the cache
so you might get an error from the bus read. Even if we known it is in the cache
(and from a quick glance I'm not sure we do as we haven't forced a full
fill of the regcache or accessed this register) from a local code point of view
it is correct to handle the potential error and pass it to higher layers.
Jonathan
>
> Best regards
> Uwe
next prev parent reply other threads:[~2024-12-28 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 9:34 [PATCH RFC v2 0/4] iio: adc: ad7380: add alert support Julien Stephan
2024-12-24 9:34 ` [PATCH RFC v2 1/4] iio: adc: ad7380: do not use iio_device_claim_direct_scoped anymore Julien Stephan
2024-12-27 8:43 ` Uwe Kleine-König
2024-12-28 13:51 ` Jonathan Cameron
2024-12-28 13:49 ` Jonathan Cameron
2024-12-24 9:34 ` [PATCH RFC v2 2/4] iio: adc: ad7380: enable regmap cache Julien Stephan
2024-12-27 8:48 ` Uwe Kleine-König
2024-12-28 14:07 ` Jonathan Cameron [this message]
2024-12-28 14:02 ` Jonathan Cameron
2024-12-24 9:34 ` [PATCH RFC v2 3/4] iio: adc: ad7380: add alert support Julien Stephan
2024-12-27 9:39 ` Uwe Kleine-König
2024-12-28 14:24 ` Jonathan Cameron
2025-01-06 15:29 ` David Lechner
2025-01-07 8:51 ` Julien Stephan
2025-01-11 12:51 ` Jonathan Cameron
2025-01-12 11:40 ` Jonathan Cameron
2024-12-24 9:34 ` [PATCH RFC v2 4/4] docs: iio: " Julien Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241228140704.7115fb23@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=jstephan@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox