From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Julien Stephan" <jstephan@baylibre.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 1/5] iio: adc: ad7380: do not use iio_device_claim_direct_scoped anymore
Date: Sun, 12 Jan 2025 16:42:01 +0000 [thread overview]
Message-ID: <20250112164201.067ecd9e@jic23-huawei> (raw)
In-Reply-To: <Z4Pt9oZEkfQMuYUm@surfacebook.localdomain>
On Sun, 12 Jan 2025 18:29:42 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> Wed, Jan 08, 2025 at 01:49:33PM +0100, Julien Stephan kirjoitti:
> > Conditionnal scoped handlers are turning out to be a real pain:
> > readability issues, compiler and linker handling issues among others so
> > rollback and remove the scoped version of iio_dvice_claim_direct_mode.
>
> Is it IIO level decision or you as a contributor to/maintainer of this driver?
> If the former? can you add a Link to the discussion?
IIO. Agreed a link would have been sensible here.
>
> Otherwise, I would like to understand the common approach / practices in IIO
> WRT individual drivers to deviate the common approaches. Jonathan?
Patch series on list ripping the whole lot out that has some more explanation
and links. Basically we never found a way to overcome the short comings of
conditional scoped guards.
https://lore.kernel.org/linux-iio/20250105172613.1204781-1-jic23@kernel.org/
Jonathan
>
next prev parent reply other threads:[~2025-01-12 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 12:49 [PATCH v4 0/5] iio: adc: ad7380: add alert support Julien Stephan
2025-01-08 12:49 ` [PATCH v4 1/5] iio: adc: ad7380: do not use iio_device_claim_direct_scoped anymore Julien Stephan
2025-01-12 16:29 ` Andy Shevchenko
2025-01-12 16:42 ` Jonathan Cameron [this message]
2025-01-12 20:19 ` Andy Shevchenko
2025-01-08 12:49 ` [PATCH v4 2/5] iio: adc: ad7380: enable regmap cache Julien Stephan
2025-01-08 12:49 ` [PATCH v4 3/5] iio: adc: ad7380: do not store osr in private data structure Julien Stephan
2025-01-12 16:31 ` Andy Shevchenko
2025-01-08 12:49 ` [PATCH v4 4/5] iio: adc: ad7380: add alert support Julien Stephan
2025-01-08 15:17 ` David Lechner
2025-01-12 11:49 ` Jonathan Cameron
2025-01-08 12:49 ` [PATCH v4 5/5] docs: iio: " Julien Stephan
2025-01-12 11:51 ` [PATCH v4 0/5] iio: adc: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250112164201.067ecd9e@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=jstephan@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox